Release v1.161.0 - staging → master #13538
reviewdog [eslint] report
reported by reviewdog 🐶
Findings (45)
packages/manager/cypress/e2e/core/cloudpulse/alert-notification-channel-edit.spec.ts|66 col 14| Define a constant instead of duplicating this literal 3 times.
packages/manager/cypress/e2e/core/cloudpulse/alert-notification-channel-edit.spec.ts|97 col 15| Define a constant instead of duplicating this literal 5 times.
packages/manager/cypress/e2e/core/cloudpulse/alert-show-notification-channel.spec.ts|184 col 33| Define a constant instead of duplicating this literal 31 times.
packages/manager/cypress/e2e/core/cloudpulse/alert-show-notification-channel.spec.ts|206 col 13| Define a constant instead of duplicating this literal 6 times.
packages/manager/cypress/e2e/core/cloudpulse/alert-show-notification-channel.spec.ts|207 col 13| Define a constant instead of duplicating this literal 4 times.
packages/manager/cypress/e2e/core/cloudpulse/alert-show-notification-channel.spec.ts|208 col 13| Define a constant instead of duplicating this literal 4 times.
packages/manager/cypress/e2e/core/cloudpulse/alert-show-notification-channel.spec.ts|273 col 12| Define a constant instead of duplicating this literal 5 times.
packages/manager/cypress/e2e/core/cloudpulse/alert-show-notification-channel.spec.ts|284 col 42| Refactor this code to not nest functions more than 4 levels deep.
packages/manager/cypress/e2e/core/cloudpulse/alert-show-notification-channel.spec.ts|307 col 14| Define a constant instead of duplicating this literal 3 times.
packages/manager/cypress/e2e/core/cloudpulse/alert-show-notification-channel.spec.ts|317 col 17| Define a constant instead of duplicating this literal 3 times.
packages/manager/cypress/e2e/core/cloudpulse/alerts-service-ld-flags.spec.ts|95 col 12| Define a constant instead of duplicating this literal 3 times.
packages/manager/cypress/e2e/core/cloudpulse/alerts-service-ld-flags.spec.ts|95 col 32| Define a constant instead of duplicating this literal 3 times.
packages/manager/src/features/Databases/DatabaseDetail/ServiceURI.test.tsx|369 col 34| Avoid direct Node access. Prefer using the methods from Testing Library.
packages/manager/src/features/Databases/DatabaseDetail/ServiceURI.test.tsx|369 col 34| Avoid direct Node access. Prefer using the methods from Testing Library.
packages/manager/src/features/Delivery/Destinations/DestinationForm/DestinationCreate.test.tsx|458 col 11| Define a constant instead of duplicating this literal 3 times.
packages/manager/src/features/Delivery/Destinations/DestinationForm/DestinationCreate.test.tsx|545 col 86| Refactor this code to not nest functions more than 4 levels deep.
packages/manager/src/features/Delivery/Shared/DestinationCustomHttpsDetailsForm.tsx|144 col 22| ** No font weight declarations in our code in order to avoid faux-bold **.
We manage font weights through font family declarations.
For example, instead of specifying fontWeight: "bold",
use: fontFamily: theme.font.bold.
packages/manager/src/features/Delivery/Streams/StreamForm/Delivery/DestinationCustomHTTPSDetailsSummary.test.tsx|33 col 7| Define a constant instead of duplicating this literal 3 times.
packages/manager/src/features/Delivery/Streams/StreamForm/Delivery/StreamFormDelivery.test.tsx|541 col 13| Define a constant instead of duplicating this literal 3 times.
packages/manager/src/features/Delivery/Streams/StreamForm/Delivery/StreamFormDelivery.test.tsx|617 col 65| Refactor this code to not nest functions more than 4 levels deep.
packages/manager/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupActionMenu.tsx|12 col 6| Complete the task associated to this "TODO" comment.
packages/manager/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsTable.tsx|186 col 31| Insert ,
packages/manager/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsView.test.tsx|59 col 23| Define a constant instead of duplicating this literal 4 times.
packages/manager/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsView.test.tsx|208 col 35| Use null instead.
packages/manager/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsView.test.tsx|211 col 34| Define a constant instead of duplicating this literal 5 times.
packages/manager/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsView.test.tsx|244 col 13| Use null instead.
packages/manager/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsView.test.tsx|255 col 26| Define a constant instead of duplicating this literal 3 times.
packages/manager/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsView.test.tsx|260 col 13| Use null instead.
packages/manager/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsView.test.tsx|265 col 34| Use null instead.
packages/manager/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsView.test.tsx|319 col 49| Group all shorthand properties at either the beginning or end of this object declaration.
packages/manager/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsView.test.tsx|358 col 13| Use null instead.
packages/manager/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsView.tsx|32 col 19| Define a constant instead of duplicating this literal 3 times.
packages/manager/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsView.tsx|112 col 18| Complete the task associated to this "TODO" comment.
packages/manager/src/features/Linodes/LinodesDetail/LinodeAlerts/AlertsPanel.tsx|5 col 10| Formik is being deprecated. Please use react-hook-form. Learn more at https://linode.github.io/manager/development-guide/15-composition.html#form-composition
packages/manager/src/features/Linodes/LinodesDetail/LinodeAlerts/AlertsPanel.tsx|5 col 10| Formik is being deprecated. Please use react-hook-form. Learn more at https://linode.github.io/manager/development-guide/15-composition.html#form-composition
packages/manager/src/features/Linodes/LinodesDetail/LinodeAlerts/LinodeAlerts.test.tsx|162 col 24| Define a constant instead of duplicating this literal 4 times.
packages/manager/src/features/Linodes/LinodesDetail/LinodeAlerts/LinodeAlerts.tsx|16 col 10| Formik is being deprecated. Please use react-hook-form. Learn more at https://linode.github.io/manager/development-guide/15-composition.html#form-composition
packages/manager/src/features/Linodes/LinodesDetail/LinodeAlerts/LinodeAlerts.tsx|16 col 10| Formik is being deprecated. Please use react-hook-form. Learn more at https://linode.github.io/manager/development-guide/15-composition.html#form-composition
packages/manager/src/features/Marketplace/ProductDetails/ContactSalesDrawer.test.tsx|37 col 14| Define a constant instead of duplicating this literal 3 times.
packages/manager/src/features/Marketplace/ProductDetails/ContactSalesDrawer.test.tsx|129 col 9| Define a constant instead of duplicating this literal 3 times.
packages/manager/src/features/Marketplace/ProductDetails/ContactSalesDrawer.test.tsx|231 col 60| Avoid direct Node access. Prefer using the methods from Testing Library.
packages/manager/src/features/Marketplace/ProductDetails/ContactSalesDrawer.test.tsx|231 col 60| Avoid direct Node access. Prefer using the methods from Testing Library.
packages/manager/src/features/Marketplace/ProductDetails/ContactSalesDrawer.tsx|73 col 14| Fast refresh only works when a file only exports components. Use a new file to share constants or functions between components.
packages/manager/src/features/ReservedIps/utils.ts|10 col 7| Complete the task associated to this "TODO" comment.
packages/manager/src/mocks/presets/crud/handlers/delivery.ts|259 col 28| Use null instead.
Filtered Findings (0)
Annotations
github-actions / eslint
[eslint] packages/manager/cypress/e2e/core/cloudpulse/alert-notification-channel-edit.spec.ts#L66 <sonarjs/no-duplicate-string>(https://sonarsource.github.io/rspec/#/rspec/S1192/javascript)
Define a constant instead of duplicating this literal 3 times.
Raw output
{"ruleId":"sonarjs/no-duplicate-string","severity":1,"message":"Define a constant instead of duplicating this literal 3 times.","line":66,"column":14,"nodeType":"Literal","endLine":66,"endColumn":36}
github-actions / eslint
[eslint] packages/manager/cypress/e2e/core/cloudpulse/alert-notification-channel-edit.spec.ts#L97 <sonarjs/no-duplicate-string>(https://sonarsource.github.io/rspec/#/rspec/S1192/javascript)
Define a constant instead of duplicating this literal 5 times.
Raw output
{"ruleId":"sonarjs/no-duplicate-string","severity":1,"message":"Define a constant instead of duplicating this literal 5 times.","line":97,"column":15,"nodeType":"Literal","endLine":97,"endColumn":27}
github-actions / eslint
[eslint] packages/manager/cypress/e2e/core/cloudpulse/alert-show-notification-channel.spec.ts#L184 <sonarjs/no-duplicate-string>(https://sonarsource.github.io/rspec/#/rspec/S1192/javascript)
Define a constant instead of duplicating this literal 31 times.
Raw output
{"ruleId":"sonarjs/no-duplicate-string","severity":1,"message":"Define a constant instead of duplicating this literal 31 times.","line":184,"column":33,"nodeType":"Literal","endLine":184,"endColumn":45}
github-actions / eslint
[eslint] packages/manager/cypress/e2e/core/cloudpulse/alert-show-notification-channel.spec.ts#L206 <sonarjs/no-duplicate-string>(https://sonarsource.github.io/rspec/#/rspec/S1192/javascript)
Define a constant instead of duplicating this literal 6 times.
Raw output
{"ruleId":"sonarjs/no-duplicate-string","severity":1,"message":"Define a constant instead of duplicating this literal 6 times.","line":206,"column":13,"nodeType":"Literal","endLine":206,"endColumn":47}
github-actions / eslint
[eslint] packages/manager/cypress/e2e/core/cloudpulse/alert-show-notification-channel.spec.ts#L207 <sonarjs/no-duplicate-string>(https://sonarsource.github.io/rspec/#/rspec/S1192/javascript)
Define a constant instead of duplicating this literal 4 times.
Raw output
{"ruleId":"sonarjs/no-duplicate-string","severity":1,"message":"Define a constant instead of duplicating this literal 4 times.","line":207,"column":13,"nodeType":"Literal","endLine":207,"endColumn":37}
github-actions / eslint
[eslint] packages/manager/cypress/e2e/core/cloudpulse/alert-show-notification-channel.spec.ts#L208 <sonarjs/no-duplicate-string>(https://sonarsource.github.io/rspec/#/rspec/S1192/javascript)
Define a constant instead of duplicating this literal 4 times.
Raw output
{"ruleId":"sonarjs/no-duplicate-string","severity":1,"message":"Define a constant instead of duplicating this literal 4 times.","line":208,"column":13,"nodeType":"Literal","endLine":208,"endColumn":37}
github-actions / eslint
[eslint] packages/manager/cypress/e2e/core/cloudpulse/alert-show-notification-channel.spec.ts#L273 <sonarjs/no-duplicate-string>(https://sonarsource.github.io/rspec/#/rspec/S1192/javascript)
Define a constant instead of duplicating this literal 5 times.
Raw output
{"ruleId":"sonarjs/no-duplicate-string","severity":1,"message":"Define a constant instead of duplicating this literal 5 times.","line":273,"column":12,"nodeType":"Literal","endLine":273,"endColumn":51}
github-actions / eslint
[eslint] packages/manager/cypress/e2e/core/cloudpulse/alert-show-notification-channel.spec.ts#L284 <sonarjs/no-nested-functions>(https://sonarsource.github.io/rspec/#/rspec/S2004/javascript)
Refactor this code to not nest functions more than 4 levels deep.
Raw output
{"ruleId":"sonarjs/no-nested-functions","severity":1,"message":"Refactor this code to not nest functions more than 4 levels deep.","line":284,"column":42,"nodeType":null,"endLine":284,"endColumn":44}
github-actions / eslint
[eslint] packages/manager/cypress/e2e/core/cloudpulse/alert-show-notification-channel.spec.ts#L307 <sonarjs/no-duplicate-string>(https://sonarsource.github.io/rspec/#/rspec/S1192/javascript)
Define a constant instead of duplicating this literal 3 times.
Raw output
{"ruleId":"sonarjs/no-duplicate-string","severity":1,"message":"Define a constant instead of duplicating this literal 3 times.","line":307,"column":14,"nodeType":"Literal","endLine":307,"endColumn":28}
github-actions / eslint
[eslint] packages/manager/cypress/e2e/core/cloudpulse/alert-show-notification-channel.spec.ts#L317 <sonarjs/no-duplicate-string>(https://sonarsource.github.io/rspec/#/rspec/S1192/javascript)
Define a constant instead of duplicating this literal 3 times.
Raw output
{"ruleId":"sonarjs/no-duplicate-string","severity":1,"message":"Define a constant instead of duplicating this literal 3 times.","line":317,"column":17,"nodeType":"Literal","endLine":317,"endColumn":30}
github-actions / eslint
[eslint] packages/manager/cypress/e2e/core/cloudpulse/alerts-service-ld-flags.spec.ts#L95 <sonarjs/no-duplicate-string>(https://sonarsource.github.io/rspec/#/rspec/S1192/javascript)
Define a constant instead of duplicating this literal 3 times.
Raw output
{"ruleId":"sonarjs/no-duplicate-string","severity":1,"message":"Define a constant instead of duplicating this literal 3 times.","line":95,"column":12,"nodeType":"Literal","endLine":95,"endColumn":30}
github-actions / eslint
[eslint] packages/manager/cypress/e2e/core/cloudpulse/alerts-service-ld-flags.spec.ts#L95 <sonarjs/no-duplicate-string>(https://sonarsource.github.io/rspec/#/rspec/S1192/javascript)
Define a constant instead of duplicating this literal 3 times.
Raw output
{"ruleId":"sonarjs/no-duplicate-string","severity":1,"message":"Define a constant instead of duplicating this literal 3 times.","line":95,"column":32,"nodeType":"Literal","endLine":95,"endColumn":46}
github-actions / eslint
[eslint] packages/manager/src/features/Databases/DatabaseDetail/ServiceURI.test.tsx#L369 <testing-library/no-node-access>(https://github.com/testing-library/eslint-plugin-testing-library/tree/main/docs/rules/no-node-access.md)
Avoid direct Node access. Prefer using the methods from Testing Library.
Raw output
{"ruleId":"testing-library/no-node-access","severity":1,"message":"Avoid direct Node access. Prefer using the methods from Testing Library.","line":369,"column":34,"nodeType":"MemberExpression","messageId":"noNodeAccess"}
github-actions / eslint
[eslint] packages/manager/src/features/Databases/DatabaseDetail/ServiceURI.test.tsx#L369 <testing-library/no-node-access>(https://github.com/testing-library/eslint-plugin-testing-library/tree/main/docs/rules/no-node-access.md)
Avoid direct Node access. Prefer using the methods from Testing Library.
Raw output
{"ruleId":"testing-library/no-node-access","severity":1,"message":"Avoid direct Node access. Prefer using the methods from Testing Library.","line":369,"column":34,"nodeType":"MemberExpression","messageId":"noNodeAccess"}
github-actions / eslint
[eslint] packages/manager/src/features/Delivery/Destinations/DestinationForm/DestinationCreate.test.tsx#L458 <sonarjs/no-duplicate-string>(https://sonarsource.github.io/rspec/#/rspec/S1192/javascript)
Define a constant instead of duplicating this literal 3 times.
Raw output
{"ruleId":"sonarjs/no-duplicate-string","severity":1,"message":"Define a constant instead of duplicating this literal 3 times.","line":458,"column":11,"nodeType":"Literal","endLine":458,"endColumn":32}
github-actions / eslint
[eslint] packages/manager/src/features/Delivery/Destinations/DestinationForm/DestinationCreate.test.tsx#L545 <sonarjs/no-nested-functions>(https://sonarsource.github.io/rspec/#/rspec/S2004/javascript)
Refactor this code to not nest functions more than 4 levels deep.
Raw output
{"ruleId":"sonarjs/no-nested-functions","severity":1,"message":"Refactor this code to not nest functions more than 4 levels deep.","line":545,"column":86,"nodeType":null,"endLine":545,"endColumn":88}
github-actions / eslint
[eslint] packages/manager/src/features/Delivery/Shared/DestinationCustomHttpsDetailsForm.tsx#L144 <@linode/cloud-manager/no-custom-fontWeight>
** No font weight declarations in our code in order to avoid faux-bold **.
We manage font weights through font family declarations.
For example, instead of specifying `fontWeight: "bold"`,
use: `fontFamily: theme.font.bold`.
Raw output
{"ruleId":"@linode/cloud-manager/no-custom-fontWeight","severity":1,"message":"** No font weight declarations in our code in order to avoid faux-bold **.\nWe manage font weights through font family declarations.\nFor example, instead of specifying `fontWeight: \"bold\"`,\nuse: `fontFamily: theme.font.bold`.","line":144,"column":22,"nodeType":"Property","endLine":144,"endColumn":77}
github-actions / eslint
[eslint] packages/manager/src/features/Delivery/Streams/StreamForm/Delivery/DestinationCustomHTTPSDetailsSummary.test.tsx#L33 <sonarjs/no-duplicate-string>(https://sonarsource.github.io/rspec/#/rspec/S1192/javascript)
Define a constant instead of duplicating this literal 3 times.
Raw output
{"ruleId":"sonarjs/no-duplicate-string","severity":1,"message":"Define a constant instead of duplicating this literal 3 times.","line":33,"column":7,"nodeType":"Literal","endLine":33,"endColumn":26}
github-actions / eslint
[eslint] packages/manager/src/features/Delivery/Streams/StreamForm/Delivery/StreamFormDelivery.test.tsx#L541 <sonarjs/no-duplicate-string>(https://sonarsource.github.io/rspec/#/rspec/S1192/javascript)
Define a constant instead of duplicating this literal 3 times.
Raw output
{"ruleId":"sonarjs/no-duplicate-string","severity":1,"message":"Define a constant instead of duplicating this literal 3 times.","line":541,"column":13,"nodeType":"Literal","endLine":541,"endColumn":34}
github-actions / eslint
[eslint] packages/manager/src/features/Delivery/Streams/StreamForm/Delivery/StreamFormDelivery.test.tsx#L617 <sonarjs/no-nested-functions>(https://sonarsource.github.io/rspec/#/rspec/S2004/javascript)
Refactor this code to not nest functions more than 4 levels deep.
Raw output
{"ruleId":"sonarjs/no-nested-functions","severity":1,"message":"Refactor this code to not nest functions more than 4 levels deep.","line":617,"column":65,"nodeType":null,"endLine":617,"endColumn":67}
github-actions / eslint
[eslint] packages/manager/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupActionMenu.tsx#L12 <sonarjs/todo-tag>(https://sonarsource.github.io/rspec/#/rspec/S1135/javascript)
Complete the task associated to this "TODO" comment.
Raw output
{"ruleId":"sonarjs/todo-tag","severity":1,"message":"Complete the task associated to this \"TODO\" comment.","line":12,"column":6,"nodeType":null,"messageId":"completeTODO","endLine":12,"endColumn":10}
github-actions / eslint
[eslint] packages/manager/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsTable.tsx#L186 <prettier/prettier>(https://github.com/prettier/eslint-plugin-prettier#options)
Insert `,`
Raw output
{"ruleId":"prettier/prettier","severity":1,"message":"Insert `,`","line":186,"column":31,"nodeType":null,"messageId":"insert","endLine":186,"endColumn":31,"fix":{"range":[5283,5283],"text":","}}
github-actions / eslint
[eslint] packages/manager/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsView.test.tsx#L59 <sonarjs/no-duplicate-string>(https://sonarsource.github.io/rspec/#/rspec/S1192/javascript)
Define a constant instead of duplicating this literal 4 times.
Raw output
{"ruleId":"sonarjs/no-duplicate-string","severity":1,"message":"Define a constant instead of duplicating this literal 4 times.","line":59,"column":23,"nodeType":"Literal","endLine":59,"endColumn":35}
github-actions / eslint
[eslint] packages/manager/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsView.test.tsx#L208 <sonarjs/no-undefined-assignment>(https://sonarsource.github.io/rspec/#/rspec/S2138/javascript)
Use null instead.
Raw output
{"ruleId":"sonarjs/no-undefined-assignment","severity":1,"message":"Use null instead.","line":208,"column":35,"nodeType":"Identifier","messageId":"useNull","endLine":208,"endColumn":44}
github-actions / eslint
[eslint] packages/manager/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsView.test.tsx#L211 <sonarjs/no-duplicate-string>(https://sonarsource.github.io/rspec/#/rspec/S1192/javascript)
Define a constant instead of duplicating this literal 5 times.
Raw output
{"ruleId":"sonarjs/no-duplicate-string","severity":1,"message":"Define a constant instead of duplicating this literal 5 times.","line":211,"column":34,"nodeType":"Literal","endLine":211,"endColumn":48}