Skip to content

refactor: STORIF-335 - Object storage drawers refactored. #13540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dchyrva-akamai wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

refactor: STORIF-335 - Object storage drawers refactored. #13540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
420d0c7
refactor: STORIF-335 - AccessKeyDrawer relpaced by OMC_AccessKeyDrawer.
dchyrva-akamai Mar 26, 2026
99e895b
refactor: STORIF-335 - Access key mutation queries created.
dchyrva-akamai Mar 26, 2026
cd6f0f2
refactor: STORIF-335 - AccessKeysDrawer refactored.
dchyrva-akamai Mar 26, 2026
22f623e
refactor: STORIF-335 - CreateBucketDrawer replaced by OMC_CreateBucke…
dchyrva-akamai Mar 26, 2026
543fd9f
refactor: STORIF-335 - BucketDrawerOutlet component created.
dchyrva-akamai Mar 26, 2026
3c94b34
refactro: STORIF-335 AccessKeysDrawerOutlet component created.
dchyrva-akamai Mar 27, 2026
722bd73
[REVERT AFTER THE REVIEW] Unrenamed files.
dchyrva-akamai Mar 27, 2026
998134e
refactor: STORIF-335 - Comments resolved.
dchyrva-akamai Mar 27, 2026
6588e54
refactor: STORIF-335 - Test fixed.
dchyrva-akamai Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 29 additions & 12 deletions packages/manager/cypress/e2e/core/objectStorage/access-key.e2e.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ describe('object storage access key end-to-end tests', () => {

mockGetAccount(accountFactory.build({ capabilities: ['Object Storage'] }));
mockAppendFeatureFlags({
objMultiCluster: false,
objectStorageGen2: { enabled: false },
objMultiCluster: true,
objectStorageGen2: { enabled: true },
});

cy.visitWithLogin('/object-storage/access-keys');
Expand All @@ -59,8 +59,14 @@ describe('object storage access key end-to-end tests', () => {
.findByTitle('Create Access Key')
.should('be.visible')
.within(() => {
cy.findByText('Label').click();
cy.focused().type(keyLabel);
cy.findByLabelText('Label', { exact: false })
.should('be.visible')
.type(keyLabel);

cy.findByLabelText('Regions', { exact: false })
.should('be.visible')
.type('Atlanta, {enter}');

ui.buttonGroup
.findButtonByTitle('Create Access Key')
.should('be.visible')
Expand Down Expand Up @@ -124,6 +130,7 @@ describe('object storage access key end-to-end tests', () => {
const bucketClusterObj = chooseCluster();
const bucketRequest = createObjectStorageBucketFactoryLegacy.build({
cluster: bucketClusterObj.id,
cors_enabled: true,
label: bucketLabel,
// Default factory sets `cluster` and `region`, but API does not accept `region` yet.
region: undefined,
Expand All @@ -140,8 +147,8 @@ describe('object storage access key end-to-end tests', () => {
accountFactory.build({ capabilities: ['Object Storage'] })
);
mockAppendFeatureFlags({
objMultiCluster: false,
objectStorageGen2: { enabled: false },
objMultiCluster: true,
objectStorageGen2: { enabled: true },
});

interceptGetAccessKeys().as('getKeys');
Expand All @@ -160,10 +167,20 @@ describe('object storage access key end-to-end tests', () => {
.findByTitle('Create Access Key')
.should('be.visible')
.within(() => {
cy.findByText('Label').click();
cy.focused().type(keyLabel);
cy.findByLabelText('Limited Access').click();
cy.findByLabelText('Select read-only for all').click();
cy.findByLabelText('Label', { exact: false })
.should('be.visible')
.type(keyLabel);

cy.findByLabelText('Regions', { exact: false })
.should('be.visible')
.type('Atlanta, {enter}');

cy.focused().click();

cy.findByLabelText('Limited Access', { exact: false }).click();
cy.findByLabelText('Select read-only for all', {
exact: false,
}).click();

ui.buttonGroup
.findButtonByTitle('Create Access Key')
Expand Down Expand Up @@ -209,8 +226,8 @@ describe('object storage access key end-to-end tests', () => {
});
});

const permissionLabel = `This token has read-only access for ${bucketClusterObj.id}-${bucketLabel}`;
cy.findByLabelText(permissionLabel).should('be.visible');
const permissionLabel = `This access key has the following permissions:`;
cy.findByText(permissionLabel).should('be.visible');
});
});
});
Expand Down
11 changes: 9 additions & 2 deletions packages/manager/cypress/e2e/core/objectStorage/access-keys.smoke.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,19 @@ describe('object storage access keys smoke tests', () => {
.findByTitle('Create Access Key')
.should('be.visible')
.within(() => {
cy.findByLabelText('Label').click();
cy.focused().type(mockAccessKey.label);
cy.findByLabelText('Label', { exact: false })
.should('be.visible')
.type(mockAccessKey.label);

cy.findByLabelText('Regions', { exact: false })
.should('be.visible')
.type('Atlanta, {enter}');

ui.buttonGroup
.findButtonByTitle('Create Access Key')
.as('qaCreateAccessKey')
.scrollIntoView();

cy.get('@qaCreateAccessKey')
.should('be.visible')
.should('be.enabled')
Expand Down
14 changes: 12 additions & 2 deletions packages/manager/cypress/e2e/core/objectStorage/enable-object-storage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,10 +298,14 @@ describe('Object Storage enrollment', () => {
.findByTitle('Create Access Key')
.should('be.visible')
.within(() => {
cy.findByLabelText('Label')
cy.findByLabelText('Label', { exact: false })
.should('be.visible')
.type(mockAccessKey.label);

cy.findByLabelText('Regions', { exact: false })
.should('be.visible')
.type('Jakarta, ID{enter}');

ui.buttonGroup
.findButtonByTitle('Create Access Key')
.should('be.visible')
Expand Down Expand Up @@ -360,7 +364,13 @@ describe('Object Storage enrollment', () => {
.findByTitle('Create Access Key')
.should('be.visible')
.within(() => {
cy.findByLabelText('Label').should('be.visible').type(randomLabel());
cy.findByLabelText('Label', { exact: false })
.should('be.visible')
.type(randomLabel());

cy.findByLabelText('Regions', { exact: false })
.should('be.visible')
.type('Jakarta, ID{enter}');

ui.buttonGroup
.findButtonByTitle('Create Access Key')
Expand Down
4 changes: 2 additions & 2 deletions packages/manager/cypress/e2e/core/objectStorage/object-storage.smoke.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ describe('object storage smoke tests', () => {
mockAppendFeatureFlags({
gecko2: false,
objMultiCluster: true,
objectStorageGen2: { enabled: false },
objectStorageGen2: { enabled: true },
}).as('getFeatureFlags');

mockGetBuckets([]).as('getBuckets');
Expand All @@ -65,7 +65,7 @@ describe('object storage smoke tests', () => {
cy.findByLabelText('Bucket Name (required)').click();
cy.focused().type(bucketLabel);
ui.regionSelect.find().click();
cy.focused().type(`${mockCluster.id}{enter}`);
cy.focused().type(`${mockRegion.label}{enter}`);
ui.buttonGroup
.findButtonByTitle('Create Bucket')
.should('be.visible')
Expand Down
2 changes: 1 addition & 1 deletion ...er/cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const emptyFolderMessage = 'This folder is empty.';
* @returns Non-empty bucket error message.
*/
const getNonEmptyBucketMessage = (bucketLabel: string) => {
return `Bucket ${bucketLabel} is not empty. Please delete all objects and try again.`;
return `The specified bucket '${bucketLabel}' is not empty. Please delete all objects before retrying.`;
};

/**
Expand Down
97 changes: 0 additions & 97 deletions packages/manager/src/features/ObjectStorage/AccessKeyLanding/AccessKeyDrawer.test.tsx
View file
Open in desktop

This file was deleted.

Loading
Loading