Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions linode/lke/framework_resource_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -820,6 +820,56 @@ func TestAccResourceLKECluster_enterprise(t *testing.T) {
})
}

func TestAccResourceLKECluster_enterpriseNoPools(t *testing.T) {
t.Parallel()

k8sVersionEnterprise = "v1.31.9+lke7"

enterpriseRegion := "us-ord"

acceptance.RunTestWithRetries(t, 2, func(t *acceptance.WrappedT) {
clusterName := acctest.RandomWithPrefix("tf-test")
resource.Test(t, resource.TestCase{
PreCheck: func() { acceptance.PreCheck(t) },
ProtoV6ProviderFactories: acceptance.ProtoV6ProviderFactories,
CheckDestroy: acceptance.CheckLKEClusterDestroy,
Steps: []resource.TestStep{
{
Config: tmpl.EnterpriseNoPools(t, clusterName, k8sVersionEnterprise, enterpriseRegion),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr(resourceClusterName, "label", clusterName),
resource.TestCheckResourceAttr(resourceClusterName, "region", enterpriseRegion),
resource.TestCheckResourceAttr(resourceClusterName, "k8s_version", k8sVersionEnterprise),
resource.TestCheckResourceAttr(resourceClusterName, "status", "ready"),
resource.TestCheckResourceAttr(resourceClusterName, "tier", "enterprise"),
resource.TestCheckResourceAttr(resourceClusterName, "pool.#", "0"),
resource.TestCheckResourceAttrSet(resourceClusterName, "kubeconfig"),
resource.TestCheckResourceAttrSet(resourceClusterName, "vpc_id"),
resource.TestCheckResourceAttrSet(resourceClusterName, "subnet_id"),
),
},
},
})
})
}

func TestAccResourceLKECluster_standardNoPools(t *testing.T) {
t.Parallel()

clusterName := acctest.RandomWithPrefix("tf-test")
resource.Test(t, resource.TestCase{
PreCheck: func() { acceptance.PreCheck(t) },
ProtoV6ProviderFactories: acceptance.ProtoV6ProviderFactories,
CheckDestroy: acceptance.CheckLKEClusterDestroy,
Steps: []resource.TestStep{
{
Config: tmpl.StandardNoPools(t, clusterName, k8sVersionLatest, testRegion),
ExpectError: regexp.MustCompile("at least one pool is required for standard tier clusters"),
},
},
})
}

func TestAccResourceLKECluster_apl(t *testing.T) {
t.Parallel()
acceptance.RunTestWithRetries(t, 2, func(t *acceptance.WrappedT) {
Expand Down
22 changes: 22 additions & 0 deletions linode/lke/resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ func Resource() *schema.Resource {
},
CustomizeDiff: customdiff.All(
customDiffValidateOptionalCount,
customDiffValidatePoolForStandardTier,
linodediffs.ComputedWithDefault("tags", []string{}),
linodediffs.CaseInsensitiveSet("tags"),
helper.SDKv2ValidateFieldRequiresAPIVersion(
Expand Down Expand Up @@ -543,3 +544,24 @@ func customDiffValidateOptionalCount(ctx context.Context, diff *schema.ResourceD

return nil
}

// customDiffValidatePoolForStandardTier ensures that at least one pool
// is defined when tier is "standard" or not set (defaults to standard).
//
// For enterprise tier clusters, pools are optional and can be empty.
func customDiffValidatePoolForStandardTier(ctx context.Context, diff *schema.ResourceDiff, meta any) error {
tier := diff.GetRawConfig().GetAttr("tier")
pool := diff.GetRawConfig().GetAttr("pool")

// If tier is not set or is set to "standard", at least one pool is required
tierIsStandard := tier.IsNull() || tier.AsString() == TierStandard

if tierIsStandard {
// Check if pool is null or empty
if pool.IsNull() || pool.LengthInt() == 0 {
return fmt.Errorf("at least one pool is required for standard tier clusters")
}
}

return nil
}
5 changes: 2 additions & 3 deletions linode/lke/schema_resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -279,9 +279,8 @@ var resourceSchema = map[string]*schema.Schema{
},
},
},
MinItems: 1,
Required: true,
Description: "A node pool in the cluster.",
Optional: true,
Description: "A node pool in the cluster. At least one pool is required for standard tier clusters.",
},
"control_plane": {
Type: schema.TypeList,
Expand Down
10 changes: 10 additions & 0 deletions linode/lke/tmpl/lke_no_pools.gotf
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{{ define "lke_no_pools" }}

resource "linode_lke_cluster" "test" {
label = "{{.Label}}"
region = "{{ .Region }}"
k8s_version = "{{.K8sVersion}}"
tier = "{{.Tier}}"
}

{{ end }}
10 changes: 10 additions & 0 deletions linode/lke/tmpl/template.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,16 @@ func EnterpriseFirewall(t testing.TB, name, version, region string, firewall_id
"lke_cluster_enterprise", TemplateData{Label: name, K8sVersion: version, Region: region, FirewallID: firewall_id})
}

func EnterpriseNoPools(t testing.TB, name, version, region string) string {
return acceptance.ExecuteTemplate(t,
"lke_no_pools", TemplateData{Label: name, K8sVersion: version, Region: region, Tier: "enterprise"})
}

func StandardNoPools(t testing.TB, name, version, region string) string {
return acceptance.ExecuteTemplate(t,
"lke_no_pools", TemplateData{Label: name, K8sVersion: version, Region: region, Tier: "standard"})
}

func DataBasic(t testing.TB, name, version, region string) string {
return acceptance.ExecuteTemplate(t,
"lke_cluster_data_basic", TemplateData{Label: name, K8sVersion: version, Region: region})
Expand Down