Add lock checks in delete functions of disk and config resources

[zliang-akamai]

📝 Description

Add checks for disks and config to prevent a locked Linode from being in an undesired state (shutdown) during deletion attempts

✔️ How to Test

Replace all tofu commands with terraform if you are using Terraform rather than OpenTofu

Applying Config with Instance, Disk, Config, and Lock

tofu apply --auto-approve

With the following TF config:

provider "linode" {}

resource "linode_instance_config" "my-config" {
  linode_id = linode_instance.my-instance.id
  label = "my-config"

  device {
    device_name = "sda"
    disk_id = linode_instance_disk.boot.id
  }
  booted = true
}

resource "linode_instance_disk" "boot" {
  label = "boot"
  linode_id = linode_instance.my-instance.id
  size = linode_instance.my-instance.specs.0.disk

  image = "linode/debian13"
  root_pass = "change-me-to-a-secure-password!!"
}

resource "linode_instance" "my-instance" {
  label = "my-instance"
  type = "g6-standard-1"
  region = "us-central"
  firewall_id = 12345 // change to your firewall
}

resource "linode_lock" "my-lock" {
  entity_id   = linode_instance.my-instance.id
  entity_type = "linode"
  lock_type   = "cannot_delete_with_subresources"
}

Remove the Lock from TF State and Config

This is necessary to test how TF reacts when attempting to delete a Linode config/disk locked by an external lock not managed by the TF.

Removing Lock from State

tofu state rm linode_lock.my-lock

Removing Lock in TF Config

provider "linode" {}

resource "linode_instance_config" "my-config" {
  linode_id = linode_instance.my-instance.id
  label = "my-config"

  device {
    device_name = "sda"
    disk_id = linode_instance_disk.boot.id
  }
  booted = true
}

resource "linode_instance_disk" "boot" {
  label = "boot"
  linode_id = linode_instance.my-instance.id
  size = linode_instance.my-instance.specs.0.disk

  image = "linode/debian13"
  root_pass = "change-me-to-a-secure-password!!"
}

resource "linode_instance" "my-instance" {
  label = "my-instance"
  type = "g6-standard-1"
  region = "us-central"
  firewall_id = 1629606
}

// The lock has been removed here

Check plan to ensure plan is empty

tofu plan

Attempt Deletion

tofu destroy --auto-approve

Verify an error similar to this appears:

╷
│ Error: can't delete config 93998593 in Linode 90484452: the resource lock on the Linode prohibits deletion of its subresources, which includes this config
│ 
│ 
╵

Also check cloud manager and verify the Linode is still in running state and wasn't powered off or shutting down

[Copilot]

Pull request overview

This PR adds lock validation to prevent deletion of disks and configs when their parent Linode instance has a cannot_delete_with_subresources lock. The changes ensure that locked Linodes remain in their current state and prevent unintended shutdowns during deletion attempts.

Changes:

• Added lock checks in disk and config deletion workflows to validate against cannot_delete_with_subresources lock type
• Introduced a helper function to check if a Linode has the cannot_delete_with_subresources lock
• Added clear error messages when deletion is blocked due to resource locks

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
linode/instancedisk/framework_resource.go	Added lock validation before disk deletion to prevent deletion when parent Linode is locked
linode/instanceconfig/resource.go	Added lock validation before config deletion to prevent deletion when parent Linode is locked
linode/helper/instance.go	Introduced helper function to check for cannot_delete_with_subresources lock on Linode instances

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.