Skip to content

soc: mspm0: add power management support #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

soc: mspm0: add power management support #214

wants to merge 5 commits into from

Conversation

@SanjayyyV
Copy link
Collaborator

  • Added power states for MSPM0
  • Added timing details for G and L series.

parthitce
parthitce reviewed Aug 12, 2025
View reviewed changes
soc/ti/mspm0/common/poweroff.c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate commit for poweroff

@SanjayyyV SanjayyyV force-pushed the upstream/ti/mspm0-soc-pm branch from 7aa1d89 to 8243a2a Compare August 12, 2025 07:29
parthitce
parthitce reviewed Aug 12, 2025
View reviewed changes
soc/ti/mspm0/CMakeLists.txt Outdated
endif()

zephyr_sources_ifdef(CONFIG_PM common/power.c)
zephyr_sources_ifdef(CONFIG_POWEROFF common/poweroff.c)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be moved to poweroff commit

parthitce
parthitce reviewed Aug 12, 2025
View reviewed changes
soc/ti/mspm0/mspm0g/Kconfig
select BUILD_OUTPUT_HEX
select HAS_MSPM0_SDK
select HAS_PM
select HAS_POWEROFF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this as well to poweroff commit

parthitce
parthitce reviewed Aug 12, 2025
View reviewed changes
soc/ti/mspm0/common/poweroff.c
int ret;
uint32_t rst_cause;

ret = hwinfo_get_reset_cause(&rst_cause);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depends on HWINFO driver

parthitce
parthitce reviewed Aug 12, 2025
View reviewed changes
soc/ti/mspm0/common/power.c Outdated
case PM_STATE_STANDBY:
set_mode_standby(substate_id);
break;
case PM_STATE_SOFT_OFF:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong placeholder. remove this

parthitce
parthitce reviewed Aug 12, 2025
View reviewed changes
soc/ti/mspm0/mspm0l/Kconfig
select BUILD_OUTPUT_HEX
select HAS_MSPM0_SDK
select HAS_PM
select HAS_POWEROFF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@parthitce
Copy link
Member

@SanjayyyV improve the commit message with details

@parthitce
Copy link
Member

@SanjayyyV #155 consider this PR as well for upstream?

@parthitce parthitce mentioned this pull request Aug 12, 2025
Open
@SanjayyyV SanjayyyV force-pushed the upstream/ti/mspm0-soc-pm branch from 8243a2a to e953568 Compare August 13, 2025 08:20
parthitce
parthitce approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@parthitce parthitce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run compliance and checkpatch stuff if not done. Otherwise LGTM.

@parthitce
Copy link
Member 

commit a2f4f2299cd6115a18f3cdf26abd22525115b5c2
Author: Parthiban Nallathambi <[email protected]>
Date:   Tue May 6 17:19:18 2025 +0530

    drivers: gpio: disable wakeup using GPIO_DISCONNECTED
    
    use GPIO_DISCONNECTED to setup disabling wakeup feature for shutdown
    mode. This also clears output and input as per the state changes of
    GPIO API.
    
    Signed-off-by: Parthiban Nallathambi <[email protected]>

commit 2eacec4495b93cd402bea6ac30a3dd64846d5d88
Author: Parthiban Nallathambi <[email protected]>
Date:   Mon May 5 10:57:34 2025 +0530

    drivers: gpio: HIGH is always 0, inversion the decision
    
    Checking against ACTIVE_HIGH is not possible as it's bit is always
    0. Check again ACTIVE_LOW and else leave it to expect ACTIVE_HIGH.
    
    Signed-off-by: Parthiban Nallathambi <[email protected]>

commit f0692fc5f66625f979212f385fef328ea3253e7b
Author: Parthiban Nallathambi <[email protected]>
Date:   Fri May 2 19:13:20 2025 +0530

    gpio: represent logic high when BIT(0) not set
    
    ACTIVE_HIGH and ACTIVE_LOW are represented in same bit i.e
    with BIT(0) set as LOW and not-set as HIGH. Deciding the wakeup
    level based on this without checking 0 for HIGH will leave
    the pin without wakeup enable. Handle with a !.
    
    Signed-off-by: Parthiban Nallathambi <[email protected]>

commit 2ba03015f41dde0762da117cce35630b4fa0a702
Author: Parthiban Nallathambi <[email protected]>
Date:   Tue Apr 29 21:07:08 2025 +0530

    drivers: gpio: add fast wake support
    
    when fast wake support is enabled, GPIO high/low level triggers
    async fast clock request if the device is in STANDBY1 low power
    state and handle the interrupt.
    
    Enable the support by handling independent pin for fast wake.
    
    Signed-off-by: Parthiban Nallathambi <[email protected]>

Cross check if we need any of this for PM. I remember this was mainly for PM in one way or another.

@SanjayyyV SanjayyyV force-pushed the upstream/ti/mspm0-soc-pm branch from e953568 to 92d09d5 Compare August 27, 2025 07:46
@github-actions
Copy link

github-actions bot commented Sep 1, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_ti zephyrproject-rtos/hal_ti@391f7cb zephyrproject-rtos/hal_ti@d062844 (master) zephyrproject-rtos/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@SanjayyyV
west.yml: Update hal_ti revision
c790220 
Update hal_ti to include input-enable property for all UART RX pins.
Without the input-enable property, UART reception does not function
correctly when the SoC enters low-power mode. Adding this property
ensures reliable UART operation in all power states.

Signed-off-by: Sanjay Vallimanalan <[email protected]>
@SanjayyyV
soc: mspm0: add power management support
0ac0e69 
TI MSPM0 series supports range of power modes (RUN/SLEEP, STOP, STANDBY)
supporting low power operations. Provides automatic restoration to
RUN mode on wakeup from any low power state.

Signed-off-by: Sanjay Vallimanalan <[email protected]>
Signed-off-by: Parthiban Nallathambi <[email protected]>
@SanjayyyV
soc: mspm0: add poweroff support
27d9843 
add support for SHUTDOWN operating mode in TI MSPM0 series for power-off
operation. Uses HWINFO for reset cause detection to handle shutdown IO
release on low power wakeup.

Signed-off-by: Sanjay Vallimanalan <[email protected]>
Signed-off-by: Parthiban Nallathambi <[email protected]>
@SanjayyyV
drivers: gpio: Add GPIO Fast Wake support
9db609a 
The fast wake feature in the MSPM0 GPIO peripheral allows the GPIO module
to stay in a low-power state and detect interrupt events on the device pins
without requiring a high-speed clock. This allows the device to support
fast wakeup from low-power modes, such as STOP and STANDBY, on any GPIO
pin.

Signed-off-by: Sanjay Vallimanalan <[email protected]>
Signed-off-by: Parthiban Nallathambi <[email protected]>
@SanjayyyV
dts: arm/ti/mspm0: add cpu power states for MSPM0 series
aaa58b1 
add range of cpu power states (run/sleep, stop and standby) for MSPM0
series. add exit latencies ranging from 1.5-15.7µs and minimum
residency times of 5-10ms for optimal power management transitions.

Signed-off-by: Sanjay Vallimanalan <[email protected]>
Signed-off-by: Parthiban Nallathambi <[email protected]>
@SanjayyyV SanjayyyV force-pushed the upstream/ti/mspm0-soc-pm branch from 66ad842 to aaa58b1 Compare September 10, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthitce parthitce parthitce approved these changes

Assignees

No one assigned

Labels

manifest manifest-hal_ti

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SanjayyyV @parthitce