Make auparse muti-thread safe #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ausearch_load_interpretations() directly calls _auparse_load_interpretations(au, n->interp) but au is a global pointer initialized only when CSV/TEXT output is selected. When using the -i option (interpreted output) au remains NULL, leading to a crash in free_interpretation_list().
There were identical stub declarations in various files. This patch gathers them all up to make future maintenance easier.
path_norm uses a static array working to build paths and then returns a copy. Concurrent calls may corrupt working before the copy is made. Now it dynamically allocates a PATH_MAX-sized buffer, handles cleanup on all return paths, and frees it before duplicating the final normalized path.
interpret.c maintains global caches (uid_cache, gid_cache) without synchronization, meaning concurrent lookups from multiple threads could race. Calls such as _auparse_flush_caches() operate on these globals, further suggesting they are shared process wide. Move the caches into the auparse_state_t variable so that the cache is private to the auparse_state_t instance.
NEVER_LOADED is defined both in interpret.h and in the stub header. Move it to a shared location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for descriptions.