Skip to content

nvme/{043,045}: use SHA-512 DH-HMAC-CHAP keys #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hreinecke wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nvme/{043,045}: use SHA-512 DH-HMAC-CHAP keys #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/nvme/043
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ test() {
local hostkey
local ctrldev

hostkey="$(nvme gen-dhchap-key -n "${def_hostnqn}" 2> /dev/null)"
hostkey="$(nvme gen-dhchap-key -3 -n "${def_hostnqn}" 2> /dev/null)"
if [ -z "$hostkey" ] ; then
echo "nvme gen-dhchap-key failed"
return 1
Expand Down
8 changes: 4 additions & 4 deletions tests/nvme/045
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,13 @@ test() {
local rand_io_size
local ns

hostkey="$(nvme gen-dhchap-key -n "${def_subsysnqn}" 2> /dev/null)"
hostkey="$(nvme gen-dhchap-key -m 3 -n "${def_subsysnqn}" 2> /dev/null)"
if [ -z "$hostkey" ] ; then
echo "failed to generate host key"
return 1
fi

ctrlkey="$(nvme gen-dhchap-key -n "${def_subsysnqn}" 2> /dev/null)"
ctrlkey="$(nvme gen-dhchap-key -m 3 -n "${def_subsysnqn}" 2> /dev/null)"
if [ -z "$ctrlkey" ] ; then
echo "failed to generate ctrl key"
return 1
Expand All @@ -69,7 +69,7 @@ test() {

echo "Renew host key on the controller"

new_hostkey="$(nvme gen-dhchap-key --nqn "${def_subsysnqn}" 2> /dev/null)"
new_hostkey="$(nvme gen-dhchap-key -m 3 -n "${def_subsysnqn}" 2> /dev/null)"

_set_nvmet_hostkey "${def_hostnqn}" "${new_hostkey}"

Expand All @@ -79,7 +79,7 @@ test() {

echo "Renew ctrl key on the controller"

new_ctrlkey="$(nvme gen-dhchap-key --nqn "${def_subsysnqn}" 2> /dev/null)"
new_ctrlkey="$(nvme gen-dhchap-key -m 3 -n "${def_subsysnqn}" 2> /dev/null)"

_set_nvmet_ctrlkey "${def_hostnqn}" "${new_ctrlkey}"

Expand Down