drbd: fix a null-pointer dereference when the request event in drbd_request_endio() is READ_COMPLETED_WITH_ERROR #450
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: aacb0a6 |
blktests-ci
bot
added
new
V1
linus-master
V1-ci-fail
V1-ci-pass
and removed
V1-ci-fail
labels
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
0ab4e8c to
a2a6d78
Compare
Author
|
Upstream branch: aacb0a6 |
blktests-ci
bot
force-pushed
the
series/1038240=>linus-master
branch
from
5591c78 to
b5e0543
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
a2a6d78 to
f962a4d
Compare
…equest_endio() is READ_COMPLETED_WITH_ERROR
In drbd_request_endio(), the request event what can be set to
READ_COMPLETED_WITH_ERROR. In this case, __req_mod() is invoked with a NULL
peer_device:
__req_mod(req, what, NULL, &m);
When handling READ_COMPLETED_WITH_ERROR, __req_mod() unconditionally calls
drbd_set_out_of_sync():
case READ_COMPLETED_WITH_ERROR:
drbd_set_out_of_sync(peer_device, req->i.sector, req->i.size);
The drbd_set_out_of_sync() macro expands to __drbd_change_sync():
#define drbd_set_out_of_sync(peer_device, sector, size) \
__drbd_change_sync(peer_device, sector, size, SET_OUT_OF_SYNC)
However, __drbd_change_sync() assumes a valid peer_device and immediately
dereferences it:
struct drbd_device *device = peer_device->device;
If peer_device is NULL, this results in a NULL-pointer dereference.
Fix this by adding a NULL check in __req_mod() before calling
drbd_set_out_of_sync().
Signed-off-by: Tuo Li <[email protected]>
Author
|
Upstream branch: 623fb99 |
blktests-ci
bot
force-pushed
the
series/1038240=>linus-master
branch
from
b5e0543 to
504689c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: drbd: fix a null-pointer dereference when the request event in drbd_request_endio() is READ_COMPLETED_WITH_ERROR
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1038240