Conversation
msirringhaus
approved these changes
Feb 24, 2026
Collaborator
msirringhaus
left a comment
msirringhaus
left a comment
There was a problem hiding this comment.
lgtm, other than one question. Approved regardless.
| operation: Operation, | ||
| rp_id: String, | ||
| requesting_app: RequestingApplication, | ||
| app_name: String, |
Collaborator
There was a problem hiding this comment.
Is there a specific reason to unbundle this?
Member
Author
There was a problem hiding this comment.
I can't remember details right now, but it helped to allow moving the strings instead of cloning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we move to the portal, we might not be able to retrieve the app name all the time. So this makes app name optional.
Also updates some docs as this has drifted a bit.