Refactor process usb state #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iinuwa
previously approved these changes
Jul 14, 2025
Member
iinuwa
left a comment
iinuwa
left a comment
There was a problem hiding this comment.
Thank you, this was much needed! :)
msirringhaus
dismissed
iinuwa’s stale review
The merge-base changed after approval.
msirringhaus
force-pushed
the
refactor_process_usb_state
branch
from
1a491bf to
4ab7623
Compare
AlfioEmanueleFresta
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on top of #52 , some refactoring as that function got quite a bit unwieldy.