-
Notifications
You must be signed in to change notification settings - Fork 5
Split UI into separate process #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't work because of the mixing of Tokio and async-std runtimes. :(
…l for public service
Add zbus debug output; allow launching server and client simultaneously.
iinuwa
commented
Aug 5, 2025
Member
Author
iinuwa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to go ahead and merge this and follow up with more PRs to clean up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was actually more complex than I wanted it to be. Because of the tokio/async-std exclusivity in the zbus package, I had to split off the UI earlier than I wanted to to make nice clean commit history.
I mucked around in Meson build files and got it to build, and then to communicate between the two processes over D-Bus. I believe I've updated all the relevant docs for now.
I tested the following, and it seems to work:
Changed
xyz.iinuwa.credentials.CredentialManagerUitoxyz.iinuwa.credentials.Credentials. The path and interface are also changed similarly.creds-uiandcredsdbinaries. The UI still needs theGSETTINGS_SCHEMA_DIRenv variable set.NotAllowedErroras the catch-all everywhere for now.TODO
credentialsdname tocredsd, so I'll probably wind up renaming that later.