Do not fail on unknown algorithms (fix #66) #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlfioEmanueleFresta
force-pushed
the
fix-ctap2-transport
branch
from
7a4dd62 to
4b7ba3f
Compare
msirringhaus
requested changes
May 27, 2025
AlfioEmanueleFresta
force-pushed
the
no-crash-unknown-algorithsm
branch
from
08399d5 to
f5770cc
Compare
msirringhaus
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows parsing unknown algorithm types without failing.
Only ES256 is every used for requests, and it's guaranteed to be supported by the spec, so checking the value is not necessary for now.