Implement discoverable credential 'preferred' #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msirringhaus
force-pushed
the
optional_discoverable_creds
branch
from
75f60be to
5990e71
Compare
iinuwa
reviewed
Jul 17, 2025
Member
iinuwa
left a comment
iinuwa
left a comment
There was a problem hiding this comment.
The whole renaming "resident keys" to be "discoverable credentials" in the spec is a debacle, but I prefer using resident key terminology in the library as it's easier to map to the spec, IMO. (E.g. resident_key_requirement and ResidentKeyRequirement rather than discoverable_credential and DiscoverableCredentialRequirement)
Not a dealbreaker for me though.
Other than that, looks good.
Collaborator
Author
|
Ugh, the webauthn spec indeed still calls it resident keys. I'll change it. |
iinuwa
approved these changes
Jul 17, 2025
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched away from a context-less
From<MakeCredentialRequest> for Ctap2MakeCredentialRequestimplementation to a dedicated function that can additionally receive the device-info to make that transformation.Now we also don't need to copy the original request and modify it (which was always a bit icky), but we can do the direct translation to the Ctap2-request.