Skip to content

Conversation

Copy link

Copilot AI commented Dec 25, 2025

RPID Validation Implementation Plan

  • Explore repository structure and understand codebase
  • Identify where RPID is used (MakeCredentialRequest, GetAssertionRequest)
  • Create RPID validation function in proto/ctap2/model.rs
  • Add validation to Ctap2PublicKeyCredentialRpEntity::new()
  • Add validation to GetAssertionRequest for relying_party_id field
  • Add comprehensive tests for RPID validation
  • Test with valid RPIDs (example.com, sub.example.com)
  • Test with invalid RPIDs (http://example.com, example.com:8080, etc.)
  • Run existing tests to ensure no regressions
  • Run linter and fix any issues
  • Review and verify all changes
Original prompt

This section details on the original issue you should resolve

<issue_title>Relying Party ID (RPID) validation</issue_title>
<issue_description></issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Relying Party ID (RPID) validation

2 participants