Implement AuthenticatorConfig #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msirringhaus
force-pushed
the
auth_config
branch
from
2163cc6 to
d9f95a8
Compare
Member
|
Thank you @msirringhaus, I will review this by tomorrow EOD. |
msirringhaus
force-pushed
the
auth_config
branch
from
d9f95a8 to
42dbc6b
Compare
AlfioEmanueleFresta
approved these changes
Jan 15, 2025
msirringhaus
force-pushed
the
auth_config
branch
from
42dbc6b to
2476944
Compare
Member
|
Thank you for your work @msirringhaus! Merging. We should add PIN management + authenticator config functionality to the README. We could do this as part of #53. |
AlfioEmanueleFresta
merged commit 417d707
into
linux-credentials:master
3 checks passed
13 tasks
Collaborator
Author
|
I was thinking about also adding all the other ctap-stuff like BioEnrollment, CredManagement, etc. as well. Or would you rather want me to also play with the caBLE-functionality? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
user_verification()to split out the calculation ofuv_auth_paramso that other commands can implement their own algorithms for it incalculate_and_set_uv_auth().Needs probably a rebase, once (if) #48 gets merged.