playbooks: ansible-lint fix fqcn

Fix fqcn ansible-lint rule violations

Fixed fqcn rule violations across 175 file(s).

Affected files include:
- playbooks/monitor-results.yml
- playbooks/roles/blktests/handlers/main.yml
- playbooks/roles/blktests/tasks/install-deps/debian/main.yml
- playbooks/roles/blktests/tasks/install-deps/main.yml
- playbooks/roles/blktests/tasks/install-deps/redhat/main.yml
... and 170 more files

Applied using the ansible-lint-fix-rules.py script with --fix=fqcn.

Generated-by: Ansible Lint (ansible-lint-fix-rules.py)
Signed-off-by: Daniel Gomez <[email protected]>

Author: dkruces

playbooks/monitor-results.yml

@@ -5,7 +5,7 @@
   become_method: sudo
   tasks:
     - name: Import optional extra_args file
-      include_vars: "{{ item }}"
+      ansible.builtin.include_vars: "{{ item }}"
       ignore_errors: true
       with_first_found:
         - files:
@@ -16,7 +16,7 @@
       tags: vars
 
     - name: Collect monitoring results without stopping monitoring
-      include_role:
+      ansible.builtin.include_role:
         name: monitoring
         tasks_from: monitor_collect_only
       when:

playbooks/roles/blktests/handlers/main.yml

@@ -1,4 +1,4 @@
 ---
 # SPDX-License-Identifier GPL-2.0+ OR MIT
 - name: Restart watchdog daemon
-  service: name="{{watchdog_service_name}}" state=restarted
+  ansible.builtin.service: name="{{watchdog_service_name}}" state=restarted

playbooks/roles/blktests/tasks/install-deps/debian/main.yml

@@ -2,22 +2,22 @@
 - name: Update apt cache
   become: true
   become_method: sudo
-  apt:
+  ansible.builtin.apt:
     update_cache: true
   tags: linux
 
 - name: Install nvme tools
   become: true
   become_method: sudo
-  apt:
+  ansible.builtin.apt:
     name:
       - nvme-cli
     update_cache: true
 
 - name: Install blktests build dependencies
   become: true
   become_method: sudo
-  apt:
+  ansible.builtin.apt:
     name:
       - bison
       - flex

playbooks/roles/blktests/tasks/install-deps/main.yml

@@ -1,12 +1,12 @@
 ---
-- include_role:
+- ansible.builtin.include_role:
     name: pkg
 
 # tasks to install dependencies for oscheck
 - name: oscheck distribution ospecific setup
-  import_tasks: tasks/install-deps/debian/main.yml
+  ansible.builtin.import_tasks: tasks/install-deps/debian/main.yml
   when: ansible_facts['os_family']|lower == 'debian'
-- import_tasks: tasks/install-deps/suse/main.yml
+- ansible.builtin.import_tasks: tasks/install-deps/suse/main.yml
   when: ansible_facts['os_family']|lower == 'suse'
-- import_tasks: tasks/install-deps/redhat/main.yml
+- ansible.builtin.import_tasks: tasks/install-deps/redhat/main.yml
   when: ansible_facts['os_family']|lower == 'redhat'

playbooks/roles/blktests/tasks/install-deps/redhat/main.yml

@@ -2,7 +2,7 @@
 - name: Install build dependencies for blktests
   become: true
   become_method: sudo
-  yum:
+  ansible.builtin.dnf:
     update_cache: true
     name: "{{ packages }}"
   vars:

playbooks/roles/blktests/tasks/install-deps/suse/main.yml

@@ -1,12 +1,12 @@
 ---
 - name: Set generic SUSE specific distro facts
-  set_fact:
+  ansible.builtin.set_fact:
     is_sle: '{{ (ansible_distribution == "SLES") or (ansible_distribution == "SLED") }}'
     is_leap: '{{ "Leap" in ansible_distribution }}'
     is_tumbleweed: '{{ "openSUSE Tumbleweed" == ansible_distribution }}'
 
 - name: Set SLE specific version labels to make checks easier
-  set_fact:
+  ansible.builtin.set_fact:
     is_sle10: '{{ ansible_distribution_major_version == "10" }}'
     is_sle11: '{{ ansible_distribution_major_version == "11" }}'
     is_sle12: '{{ ansible_distribution_major_version == "12" }}'
@@ -24,7 +24,7 @@
     - is_sle|bool
 
 - name: Set SLE specific version labels to make checks easier when not SLE
-  set_fact:
+  ansible.builtin.set_fact:
     is_sle10: false
     is_sle11: false
     is_sle12: false
@@ -42,22 +42,22 @@
     - not is_sle|bool
 
 - name: By default we assume we have figured out how to add repos on a release
-  set_fact:
+  ansible.builtin.set_fact:
     repos_present: true
 
 - name: Lets us disable things which require a zypper repo present
-  set_fact:
+  ansible.builtin.set_fact:
     repos_present: false
   when:
     - is_sle|bool
     - is_sle10|bool or is_sle11|bool
 
 - name: The default is to assume all distros supports nvme-utils
-  set_fact:
+  ansible.builtin.set_fact:
     lacks_nvme_utils: false
 
 - name: Does this release lack nvme-utils
-  set_fact:
+  ansible.builtin.set_fact:
     lacks_nvme_utils: true
   when:
     - is_sle|bool
@@ -167,35 +167,35 @@
     - is_sle15sp2|bool or is_sle15sp3|bool
 
 - name: The default is to assume we do not want to add the benchmark repo
-  set_fact:
+  ansible.builtin.set_fact:
     add_benchmark_repo: false
 
 - name: Does this release require the benchmark repo
-  set_fact:
+  ansible.builtin.set_fact:
     add_benchmark_repo: true
   when:
     - is_sle15sp2|bool or is_sle15sp3|bool or is_sle15sp4|bool or is_sle12sp5|bool
 
 - name: Add benchmark sles12sp5 opensuse repo when needed
   become: true
   become_method: sudo
-  script:
+  ansible.builtin.script:
     cmd: "{{ role_path }}/scripts/add-suse-repo-if-not-found.sh http://download.opensuse.org/repositories/benchmark/SLE_12_SP5/ benchmark benchmark"
   when:
     - is_sle12sp5|bool
 
 - name: Add benchmark sles15sp2 opensuse repo when needed
   become: true
   become_method: sudo
-  script:
+  ansible.builtin.script:
     cmd: "{{ role_path }}/scripts/add-suse-repo-if-not-found.sh http://download.opensuse.org/repositories/benchmark/SLE_15_SP2/ benchmark benchmark"
   when:
     - is_sle15sp2|bool
 
 - name: Add benchmark sles15sp3 opensuse repo when needed
   become: true
   become_method: sudo
-  script:
+  ansible.builtin.script:
     cmd: "{{ role_path }}/scripts/add-suse-repo-if-not-found.sh http://download.opensuse.org/repositories/benchmark/SLE_15_SP3/ benchmark benchmark"
   when:
     - is_sle15sp3|bool or is_sle15sp4|bool
@@ -211,11 +211,11 @@
     - add_benchmark_repo|bool
 
 - name: The default is to assume we do not want to to compile nbd manually
-  set_fact:
+  ansible.builtin.set_fact:
     compile_nbd: false
 
 - name: Set when we need to compile nbd
-  set_fact:
+  ansible.builtin.set_fact:
     compile_nbd: true
   when:
     - is_sle15sp2|bool or is_sle15sp3|bool or is_sle15sp4|bool or is_leap|bool
@@ -232,7 +232,7 @@
     - compile_nbd|bool
 
 - name: git clone nbd
-  git:
+  ansible.builtin.git:
     repo: "{{ nbd_git }}"
     dest: "{{ nbd_data }}"
     update: true
@@ -243,7 +243,7 @@
   tags: ["git", "blktests", "nbd"]
 
 - name: Skip documentation for nbd as we lack the requirement of docbook2man
-  file:
+  ansible.builtin.file:
     path: "{{ nbd_data }}/man/{{ item }}"
     state: touch
   with_items:
@@ -260,33 +260,33 @@
     - compile_nbd|bool
 
 - name: Run autogen for nbd
-  command: "./autogen.sh"
+  ansible.builtin.command: "./autogen.sh"
   tags: ["blktests", "nbd"]
   args:
     chdir: "{{ nbd_data }}"
 
 - name: Run configure for nbd
-  command: "./configure"
+  ansible.builtin.command: "./configure"
   tags: ["blktests", "nbd"]
   args:
     chdir: "{{ nbd_data }}"
 
 - name: Get nproc
-  command: "{{ num_jobs }}"
+  ansible.builtin.command: "{{ num_jobs }}"
   tags: ["git", "blktests", "nbd"]
   register: nproc
 
 - name: Build nbd
   tags: ["git", "blktests", "nbd"]
-  make:
+  community.general.make:
     chdir: "{{ nbd_data }}"
     jobs: "{{ nproc.stdout }}"
 
 - name: Install nbd
   become: true
   become_flags: "su - -c"
   become_method: sudo
-  command: "{{  make }} install"
+  ansible.builtin.command: "{{  make }} install"
   tags: ["git", "blktests", "nbd"]
   args:
     chdir: "{{ nbd_data }}"