tests: add initial test set #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igoropaniuk
force-pushed
the
vip_dry_run_github_action
branch
12 times, most recently
from
f3ae7e2 to
2ecd80c
Compare
lumag
requested changes
Jun 17, 2025
igoropaniuk
force-pushed
the
vip_dry_run_github_action
branch
3 times, most recently
from
f9f72a9 to
30879be
Compare
lumag
approved these changes
Jun 17, 2025
Contributor
|
Why did you add the 'test' files in .github, instead of making them part of the project, like a 'tests' folder which could be exercised with 'make tests'? |
Contributor
Author
|
@ndechesne actually that's a great idea, will take a look |
igoropaniuk
force-pushed
the
vip_dry_run_github_action
branch
from
30879be to
2dfd4fd
Compare
igoropaniuk
changed the title
igoropaniuk
force-pushed
the
vip_dry_run_github_action
branch
3 times, most recently
from
48ede1a to
3994e83
Compare
lumag
requested changes
Jun 17, 2025
Contributor
Author
|
@ndechesne @lumag reworked, please take a look |
igoropaniuk
force-pushed
the
vip_dry_run_github_action
branch
from
3994e83 to
c104d02
Compare
igoropaniuk
force-pushed
the
vip_dry_run_github_action
branch
from
c104d02 to
598cecb
Compare
igoropaniuk
force-pushed
the
vip_dry_run_github_action
branch
from
598cecb to
28efa9e
Compare
Add tests make target and a simple test that executes qdl in dry-run mode for a synthetic reference FLAT build with VIP table generation. The FLAT build contains: - patch0.xml - patch1.xml - rawprogram0.xml - rawprogram1.xml All binaries that these XML files point to are filled with zeros, generated during github action execution. Tests ensures that the table is generated correctly by comparing calculated and expected SHA256 hashes of DigestToSign.bin file. Signed-off-by: Igor Opaniuk <[email protected]>
igoropaniuk
force-pushed
the
vip_dry_run_github_action
branch
from
28efa9e to
9c707ff
Compare
lumag
approved these changes
Jun 17, 2025
quic-kdybcio
approved these changes
Jun 17, 2025
Contributor
Author
|
Is there anything else needed to be done in this PR to get it merged? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests make target and a simple test that executes qdl in dry-run mode
for a synthetic reference FLAT build with VIP table generation.
The FLAT build contains:
All binaries that these XML files point to are filled with zeros, generated
during github action execution.
Tests ensures that the table is generated correctly by comparing
calculated and expected SHA256 hashes of DigestToSign.bin file.