RFC: implement version information#90
Merged
andersson merged 6 commits intolinux-msm:masterfrom Jan 21, 2025
Merged
Conversation
In order to implement a proper versioning scheme, let's generate a version.h file that defines VERSION variable built from git workspace. The version format will be v<MAJOR>.<MINOR>-<COMMIT##>-<SHA1> Where: * MAJOR and MINOR are from the most recent tag * COMMIT## is the number of commits since last tag, to ensure incremental numbering * SHA1 is an abbreviated representation of the actual commit SHA. This requires building from a git workspace, with we are effectively calling 'git describe' during the build. We then define print_version() utility function to be used by all programs. Ensure that util.c depends on version.h and that we only update version.h timestamps when the version actually changes to avoid unnecessary rebuilds. Signed-off-by: Nicolas Dechesne <nicolas.dechesne@oss.qualcomm.com>
* add --version CLI option * dislay version when running in --debug mode Signed-off-by: Nicolas Dechesne <nicolas.dechesne@oss.qualcomm.com>
It was missing , it will be used to show the version when running in debug mode. Signed-off-by: Nicolas Dechesne <nicolas.dechesne@oss.qualcomm.com>
* add --version CLI option * dislay version when running in --debug mode Signed-off-by: Nicolas Dechesne <nicolas.dechesne@oss.qualcomm.com>
* add --version CLI option * dislay version when running in --debug mode Signed-off-by: Nicolas Dechesne <nicolas.dechesne@oss.qualcomm.com>
If for any reasons git describe does not work (git not installed, or not running from a git workspace), set VERSION to unknown-version. Signed-off-by: Nicolas Dechesne <nicolas.dechesne@oss.qualcomm.com>
|
Did a clone and build on WSL: This change will make flashing & release management much less ambiguous for everyone working with QDL. This allows the creation of compatibility matrices with BSP releases x QDL versions. Thank you so much 😄 |
obbardc
approved these changes
Jan 18, 2025
This was referenced Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40