Some fixes for --version argument. #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the build fails when parallelised with: make[1]: *** No rule to make target 'version.h', needed by 'util.o'. Stop. Fix the name of the Makefile dependency to fix the build error. Fixes: linux-msm#91 Closes: linux-msm#92 Signed-off-by: Christopher Obbard <[email protected]>
The variable name VERSION is more descriptive of the code than GITREF. Use VERSION instead. Signed-off-by: Christopher Obbard <[email protected]>
In some environments where git isn't present (e.g. in Debian pbuilder), building qdl fails due. Fix the order such that we check if VERSION is provided first & use that, only if VERSION is not provided then call git directly to get the version. Signed-off-by: Christopher Obbard <[email protected]>
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fixes for two errors:
See commit messages for details.
cc @ndechesne @andersson @quic-bjorande