contest: vmksft-p: allow dup spaces in nested tests #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakub recently reported that MPTCP nested tests were not properly parsed due to the presence of multiple whitespaces before the directive delimiter (#), e.g. ok 46 - mptcp_connect: peek mode: saveWithPeek: ns1 MPTCP -> ns1 (10.0.1.1:10043 ) TCP # time=5693ms TAP 14 explicitly allow having multiple whitespaces around the directive delimiter, but TAP 13 and KTAP doesn't mention anything about them. Anyway, it is easy to supported them by tweaking the regex to allow multiple whitespaces around the '#' character. Suggested-by: Jakub Kicinski <[email protected]> Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jakub recently reported that MPTCP nested tests were not properly parsed due to the presence of multiple whitespaces before the directive delimiter (
#), e.g.TAP 14 explicitly allow having multiple whitespaces around the directive delimiter, but TAP 13 and KTAP doesn't mention anything about them. Anyway, it is easy to supported them by tweaking the regex to allow multiple whitespaces around the
#character.Suggested-by: Jakub Kicinski