Skip to content

Fix a memory leak issue with ynl #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2025
Merged

Fix a memory leak issue with ynl #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
689d045
Fix a memory leak issue with ynl
Jul 30, 2025
8447070
Also fix duplicate #include headers in ethtool-user.cpp. And regenera…
DuoYi Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
171 changes: 83 additions & 88 deletions generated/ethtool-user.cpp
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 1 addition & 6 deletions generated/ethtool-user.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,8 @@

#include "ynl.hpp"

#include <linux/ethtool_netlink_generated.h>
#include <linux/ethtool.h>
#include <linux/ethtool.h>
#include <linux/ethtool.h>
#include <linux/ethtool.h>
#include <linux/ethtool.h>
#include <linux/ethtool.h>
#include <linux/ethtool_netlink_generated.h>

namespace ynl_cpp {
const struct ynl_family& get_ynl_ethtool_family();
Expand Down
2 changes: 1 addition & 1 deletion generated/mptcp_pm-user.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ int mptcp_pm_get_addr_rsp_parse(const struct nlmsghdr *nlh,
return YNL_PARSE_CB_ERROR;

parg.rsp_policy = &mptcp_pm_address_nest;
parg.data = &dst->addr;
parg.data = &dst->addr.emplace();
if (mptcp_pm_address_parse(&parg, attr))
return YNL_PARSE_CB_ERROR;
}
Expand Down
6 changes: 3 additions & 3 deletions generated/net_shaper-user.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,15 +236,15 @@ int net_shaper_get_rsp_parse(const struct nlmsghdr *nlh,
return YNL_PARSE_CB_ERROR;

parg.rsp_policy = &net_shaper_handle_nest;
parg.data = &dst->parent;
parg.data = &dst->parent.emplace();
if (net_shaper_handle_parse(&parg, attr))
return YNL_PARSE_CB_ERROR;
} else if (type == NET_SHAPER_A_HANDLE) {
if (ynl_attr_validate(yarg, attr))
return YNL_PARSE_CB_ERROR;

parg.rsp_policy = &net_shaper_handle_nest;
parg.data = &dst->handle;
parg.data = &dst->handle.emplace();
if (net_shaper_handle_parse(&parg, attr))
return YNL_PARSE_CB_ERROR;
} else if (type == NET_SHAPER_A_METRIC) {
Expand Down Expand Up @@ -417,7 +417,7 @@ int net_shaper_group_rsp_parse(const struct nlmsghdr *nlh,
return YNL_PARSE_CB_ERROR;

parg.rsp_policy = &net_shaper_handle_nest;
parg.data = &dst->handle;
parg.data = &dst->handle.emplace();
if (net_shaper_handle_parse(&parg, attr))
return YNL_PARSE_CB_ERROR;
}
Expand Down
8 changes: 4 additions & 4 deletions generated/netdev-user.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,7 +631,7 @@ int netdev_page_pool_get_rsp_parse(const struct nlmsghdr *nlh,
return YNL_PARSE_CB_ERROR;

parg.rsp_policy = &netdev_io_uring_provider_info_nest;
parg.data = &dst->io_uring;
parg.data = &dst->io_uring.emplace();
if (netdev_io_uring_provider_info_parse(&parg, attr))
return YNL_PARSE_CB_ERROR;
}
Expand Down Expand Up @@ -713,7 +713,7 @@ int netdev_page_pool_stats_get_rsp_parse(const struct nlmsghdr *nlh,
return YNL_PARSE_CB_ERROR;

parg.rsp_policy = &netdev_page_pool_info_nest;
parg.data = &dst->info;
parg.data = &dst->info.emplace();
if (netdev_page_pool_info_parse(&parg, attr))
return YNL_PARSE_CB_ERROR;
} else if (type == NETDEV_A_PAGE_POOL_STATS_ALLOC_FAST) {
Expand Down Expand Up @@ -859,15 +859,15 @@ int netdev_queue_get_rsp_parse(const struct nlmsghdr *nlh,
return YNL_PARSE_CB_ERROR;

parg.rsp_policy = &netdev_io_uring_provider_info_nest;
parg.data = &dst->io_uring;
parg.data = &dst->io_uring.emplace();
if (netdev_io_uring_provider_info_parse(&parg, attr))
return YNL_PARSE_CB_ERROR;
} else if (type == NETDEV_A_QUEUE_XSK) {
if (ynl_attr_validate(yarg, attr))
return YNL_PARSE_CB_ERROR;

parg.rsp_policy = &netdev_xsk_info_nest;
parg.data = &dst->xsk;
parg.data = &dst->xsk.emplace();
if (netdev_xsk_info_parse(&parg, attr))
return YNL_PARSE_CB_ERROR;
}
Expand Down
Loading