tree: always set the host key#1041
Merged
igaw merged 2 commits intolinux-nvme:masterfrom Jul 25, 2025
Merged
Conversation
igaw
force-pushed
the
fix-scan-sysfs-dhchap
branch
2 times, most recently
from
8a09833 to
283c9c1
Compare
When the transport is pcie the port_obj is leaked. Signed-off-by: Daniel Wagner <wagi@kernel.org>
The current logic will not set the host secret to the controller when the sysfs value and the value from the host object are identically. Setting the secret from the host object to the controller is not what this function is supposed to do. It should read the value from the sysfs. Signed-off-by: Daniel Wagner <wagi@kernel.org>
igaw
force-pushed
the
fix-scan-sysfs-dhchap
branch
from
283c9c1 to
d724952
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current logic will not set the host secret to the controller when
the sysfs value and the value from the host object are identically.
Thus, if the controller has a host key us this one and add it to
controller, if missing try to use the one from the host object.
Signed-off-by: Daniel Wagner wagi@kernel.org