linux: Add functions to set and clear etdas bit#1044
Closed
jeff-lien-sndk wants to merge 1 commit intolinux-nvme:masterfrom
Closed
linux: Add functions to set and clear etdas bit#1044jeff-lien-sndk wants to merge 1 commit intolinux-nvme:masterfrom
jeff-lien-sndk wants to merge 1 commit intolinux-nvme:masterfrom
Conversation
To retrieve telemetry log data area 4, the Extended Telemetry Data Area 4 Supported in the Host Behavior Support feature needs to be set. The bit will be cleared after the log has been retrieved. This commit will add functions to set and clear that bit. Signed-off-by: jeff-lien-sndk <jeff.lien@sandisk.com>
Contributor
Author
|
@igaw Do you handle libnvme maintainer duties as well? Just wondering if there's something more needed for this PR. There's been no activity since I created it. |
Collaborator
|
Yes, I am handling this project as well. Sorry just got a lot of work on my plate and haven't found time to look into till now. |
Collaborator
|
I've merged my updated version which uses the early return pattern which is used in libnvme. Please check if I got everything right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To retrieve telemetry log data area 4, the Extended Telemetry Data Area 4 Supported in the Host Behavior Support feature needs to be set. The bit will be cleared after the log has been retrieved. This commit will add functions to set and clear that bit.