Skip to content

Conversation

@sc108-lee
Copy link
Contributor

ocp-nvme: Add LMDATA-37 for Latency Monitor Log
3cc2860 commit removed

@igaw
Copy link
Collaborator

igaw commented Nov 12, 2024

Could update the commit message so that it doesn't contain a github reference. The rev is not a valid (it's not part of this repository). Also use something like git show -s --pretty='format:%h (\"%s\")\n' --abbrev=12 (I have this as alias in .gitconfig 'one', so I can do git one $rev) to give the rev a bit of a meaning: 5572c9072b7e ("tests: Use raw string for compiling regex")

Thanks

commit a5f155c ("ocp-nvme: Add LMDATA-37 for Latency Monitor Log")

Signed-off-by: Steven Seungcheol Lee <[email protected]>
@sc108-lee
Copy link
Contributor Author

Thanks for your feedback, Updated as you recommanded !

@igaw igaw merged commit 454893a into linux-nvme:master Nov 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants