Skip to content

ocp-nvme: fix the error display of Hardware Component Log #2569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
YUEyuan310 wants to merge 3 commits into from
Closed

ocp-nvme: fix the error display of Hardware Component Log #2569

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
196b717
ocp-nvme: fix the error display of Hardware Component Log
Nov 13, 2024
9a7e90f
Update ocp-print-stdout.c
YUEyuan310 Nov 13, 2024
5fc6f9d
Merge branch 'linux-nvme:master' into master
YUEyuan310 Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion plugins/ocp/ocp-print-stdout.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ static void stdout_hwcomp_log(struct hwcomp_log *log, __u32 id, bool list)
struct hwcomp_desc_entry e = { log->desc };

long double log_size = uint128_t_to_double(le128_to_cpu(log->size)) * sizeof(__le32);
size_t desc_offset = offsetof(struct hwcomp_log, desc);

printf("Log Identifier: 0x%02xh\n", LID_HWCOMP);
printf("Log Page Version: 0x%x\n", le16_to_cpu(log->ver));
Expand All @@ -41,7 +42,7 @@ static void stdout_hwcomp_log(struct hwcomp_log *log, __u32 id, bool list)
printf("Hardware Component Log Size: 0x%"PRIx64"\n", (uint64_t)log_size);
print_array("Reserved48", log->rsvd48, ARRAY_SIZE(log->rsvd48));
printf("Component Descriptions\n");
while (log_size > 0) {
while (log_size - desc_offset > 0) {
e.date_lot_size = le64_to_cpu(e.desc->date_lot_size) * sizeof(__le32);
e.date_lot_code = e.date_lot_size ? (__u8 *)e.desc + date_lot_code_offset : NULL;
e.add_info_size = le64_to_cpu(e.desc->add_info_size) * sizeof(__le32);
Expand Down