fabrics: update return values for dim #2575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igaw
requested changes
Nov 21, 2024
Collaborator
igaw
left a comment
igaw
left a comment
There was a problem hiding this comment.
use nvme_status_to_errno instead returning the status directly.
The nvme dim command returns a zero even for failure scenarios as shown below: nvme0 DIM register command error. Status:0xffffffff - Operation not supported echo $? 0 Fix this by ensuring appropriate values are returned for success and failure scenarios. And while at it, remove a couple of superfluous braces too here. Signed-off-by: Martin George <[email protected]>
martin-gpy
force-pushed
the
nvme_dim_return
branch
from
6637948 to
526be99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nvme dim command returns a zero even for failure scenarios as shown below:
nvme0 DIM register command error. Status:0xffffffff - Operation not supported
echo $?
0
Fix this by ensuring appropriate values are returned for success and failure scenarios. And while at it, remove a couple of superfluous braces too here.