Skip to content

Conversation

@sc108-lee
Copy link
Contributor

Based #2570 spec modification based ocp2.6

Log Identifier C6h
Hardware Component Log Size (bytes)
Component Identifier added
0x000C Born on Date. The date on which the device was manufactured.
ASCII string format is MMDDYYYY.

Copy link
Contributor

@ikegami-t ikegami-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way only changed the hardware component log size and added the component ID born on date for the log page by OCP verion 2.6? Is there any documentation or information for the changes version 2.6? Should we compare the documentation with the older version documentation? (I did this before to check the OCP 2.5 changes..)

@sc108-lee
Copy link
Contributor Author

By the way only changed the hardware component log size and added the component ID born on date for the log page by OCP verion 2.6? Is there any documentation or information for the changes version 2.6? Should we compare the documentation with the older version documentation? (I did this before to check the OCP 2.5 changes..)

I coun't find any documentation. I just read up latest version of spec.
Thanks for the review, Good point!
This is the only changes for hardware component log.
But I guess there are more changes for OCP 2.6.

Updated :)

I think after apply this commit, we should do some more fixes.
Currently this feature does not support huge size of log page.
(d_raw, get_log, argument)

@sc108-lee sc108-lee closed this Nov 20, 2024
@sc108-lee sc108-lee reopened this Nov 20, 2024
@sc108-lee
Copy link
Contributor Author

sc108-lee commented Nov 20, 2024

https://www.opencompute.org/events/past-events/2024-ocp-storage-tech-talk
(Datacenter NVMe SSD Specification v2.6: Updates)

I could find a documentation, but I don't think this doc checks everything. (since there is no Hardware Component Log change)
check it out.

@ikegami-t
Copy link
Contributor

The changes look good. Thank you so much for your information. Just watched the OCP video for several 10 minutes and very interesting so will check more later since the play time is long.

@igaw
Copy link
Collaborator

igaw commented Nov 21, 2024

@sc108-lee could you rebase this PR? Looks like it conflicts with the merge from #2570. Thanks

Log Identifier C6h
Hardware Component Log Size (bytes)
Component Identifier added
0x000C Born on Date. The date on which the device was manufactured.
ASCII string format is MMDDYYYY.

Signed-off-by: Steven Seungcheol Lee <[email protected]>
@sc108-lee
Copy link
Contributor Author

@igaw rebased :)

@igaw igaw merged commit 1e842b6 into linux-nvme:master Nov 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants