Skip to content

Conversation

@ikegami-t
Copy link
Contributor

The command and parameter changed by the muon commits below.
eec469bb ("bootstrap.sh - use muon-bootstrap as exe name")
5a64dfd3 ("disable bestline by default")

@ikegami-t
Copy link
Contributor Author

ikegami-t commented Nov 30, 2024

This change is for the issue #2108 #2590 but still the muon build test error below caused.

[tokunori@localhost nvme-cli]$ ./scripts/build.sh -m muon
...
c compiler: supports argument '-std=c99': YES
configuring '/home/tokunori/nvme-cli/.build-tools/build-muon/src/version.c'
warn libpkgconf not enabled
warn dependency ['libcurl'] not found
warn libpkgconf not enabled
warn dependency ['libarchive'] not found
warn libpkgconf not enabled
fallback ['pkgconf', 'dep_libpkgconf'] failed for 'libpkgconf'
fallback ['pkgconf', 'dep_libpkgconf'] failed for 'libpkgconf'
warn dependency ['libpkgconf'] not found
warn libpkgconf not enabled
[tinyjson] entering subproject 'tinyjson'
[tinyjson] configuring 'tiny-json', version: undefined
found dependency 'tinyjson' (declared dependency) version undefined static
warn libpkgconf not enabled
warn dependency ['tracy'] not found
/home/tokunori/nvme-cli/.build-tools/muon/tests/project/meson.build:397:23: error cannot return the full_path() of an external program with multiple elements (have: ['/home/tokunori/nvme-cli/.build-tools/muon/stage1/muon-bootstrap', 'samu'])

397 |         ninja = ninja.full_path()
                            ^__________
/home/tokunori/nvme-cli/.build-tools/muon/tests/project/meson.build:397:23: error in function full_path
397 |         ninja = ninja.full_path()
                            ^__________
/home/tokunori/nvme-cli/.build-tools/muon/tests/meson.build:10:1: error in function subdir
 10 | subdir('project')
      ^________________
/home/tokunori/nvme-cli/.build-tools/muon/meson.build:157:1: error in function subdir
157 | subdir('tests')
      ^______________
[tokunori@localhost nvme-cli]$ 

Seems needed to disable the muon build test since the build.sh commented out the muon build test as below.

tools_build_muon() {
...
    # "${TOOLDIR}/build-muon/muon" \
    #    -C "${TOOLDIR}/build-muon" test

By the way seems needed to stop to use and build the latest muon always since sometimes a build error happened.

The command and parameter changed by the muon commits below.
  eec469bb ("bootstrap.sh - use muon-bootstrap as exe name")
  5a64dfd3 ("disable bestline by default")

Signed-off-by: Tokunori Ikegami <[email protected]>
@igaw
Copy link
Collaborator

igaw commented Dec 2, 2024

BTW, I've disabled the muon test because they are adding to the build time. But since we started to use prebuild muon and samurai we could enable them back again.

@igaw
Copy link
Collaborator

igaw commented Dec 2, 2024

Thank you for your support. I successfully completed the compilation using the new build.sh file, But there is a problem with the executable program I compiled, it cannot execute plugin commands (eg: nvme Intel smart log add/dev/nvme1n1)

Please open a new issue and do not biggy pack on other reports.

@igaw igaw merged commit c8ffffc into linux-nvme:master Dec 2, 2024
17 checks passed
@igaw
Copy link
Collaborator

igaw commented Dec 2, 2024

Thanks!

@ikegami-t
Copy link
Contributor Author

Thanks for the build testing. About the plugins features since currently only the ocp plugin feature supported by the muon build as fixed by the PR #2503 changes before. So later I will do try to fix other plugsin features also including the intel to support by the muon build. For the deatil currently the json not supported by the muon build then almost plugin features exluding ocp needed to use the json support then the plugin features not supprted by the muon build.
About the muon test noted it so I will do investigate more later. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants