Skip to content

nvme-print-stdout: print MAXWZD and NSZS bits of ONCS field #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igaw merged 2 commits into from
Dec 4, 2024
Merged

nvme-print-stdout: print MAXWZD and NSZS bits of ONCS field #2598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ddf835
build: bump libnvme wrap
francispravin5 Dec 4, 2024
e1b7479
nvme-print-stdout: print MAXWZD and NSZS bits of ONCS field
francispravin5 Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions nvme-print-stdout.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2178,7 +2178,9 @@ static void stdout_id_ctrl_cqes(__u8 cqes)
static void stdout_id_ctrl_oncs(__le16 ctrl_oncs)
{
__u16 oncs = le16_to_cpu(ctrl_oncs);
__u16 rsvd = oncs >> 11;
__u16 rsvd13 = oncs >> 13;
bool nszs = !!(oncs & NVME_CTRL_ONCS_NAMESPACE_ZEROES);
bool maxwzd = !!(oncs & NVME_CTRL_ONCS_WRITE_ZEROES_DEALLOCATE);
bool afc = !!(oncs & NVME_CTRL_ONCS_ALL_FAST_COPY);
bool csa = !!(oncs & NVME_CTRL_ONCS_COPY_SINGLE_ATOMICITY);
bool copy = !!(oncs & NVME_CTRL_ONCS_COPY);
Expand All @@ -2191,8 +2193,12 @@ static void stdout_id_ctrl_oncs(__le16 ctrl_oncs)
bool wunc = !!(oncs & NVME_CTRL_ONCS_WRITE_UNCORRECTABLE);
bool cmp = !!(oncs & NVME_CTRL_ONCS_COMPARE);

if (rsvd)
printf(" [15:11] : %#x\tReserved\n", rsvd);
if (rsvd13)
printf(" [15:13] : %#x\tReserved\n", rsvd13);
printf(" [12:12] : %#x\tNamespace Zeroes %sSupported\n",
nszs, nszs ? "" : "Not ");
printf(" [11:11] : %#x\tMaximum Write Zeroes with Deallocate %sSupported\n",
maxwzd, maxwzd ? "" : "Not ");
printf(" [10:10] : %#x\tAll Fast Copy %sSupported\n",
afc, afc ? "" : "Not ");
printf(" [9:9] : %#x\tCopy Single Atomicity %sSupported\n",
Expand Down
2 changes: 1 addition & 1 deletion subprojects/libnvme.wrap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[wrap-git]
url = https://github.com/linux-nvme/libnvme.git
revision = 5f89dfd392ea87ce69cf27b19b0a4a73a4b4d31b
revision = b50a076515b25feaaf5646df20bded99b2b90a3b

[provide]
libnvme = libnvme_dep
Expand Down
Loading