tests: various improvements #2610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing the `nvme_bin` config to point to a different nvme-cli binary. With this change all nvme cmd strings are reworked for uniformity. This includes using f-strings and expanding short options into long options. Signed-off-by: Dennis Maisenbacher <[email protected]>
To make the parsing of nvme cmd output easier use the json output when possible. Refactoring code snippets that needed to be touched when adjusing for json output. Signed-off-by: Dennis Maisenbacher <[email protected]>
When running I/O use the current LBA format as default block size. Signed-off-by: Dennis Maisenbacher <[email protected]>
Removing sleep statements, which improves the test cases runtime. Signed-off-by: Dennis Maisenbacher <[email protected]>
Remove unused prints and add some informative prints. Signed-off-by: Dennis Maisenbacher <[email protected]>
Don't use stdout=PIPE with subprocess.call as noted in the documentation: https://docs.python.org/3/library/subprocess.html#subprocess.call Signed-off-by: Dennis Maisenbacher <[email protected]>
Using the pre-build linux-nvme/debian.python container to avoid installing dependencies every time which fails occasionally. Also drop clean up steps as this is part of the self-hosted runner now. Signed-off-by: Dennis Maisenbacher <[email protected]>
MaisenbacherD
force-pushed
the
master
branch
from
275e421 to
9afc101
Compare
Contributor
Author
|
I addressed the checkpatch errors :) |
Contributor
Author
|
A new self-hosted GitHub runner instance was added. Thanks @igaw :) |
Collaborator
|
Are these changes ready to merge? |
Contributor
Author
|
Yes, from my side these changes are ready to be merged :) |
Collaborator
|
There we go. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces various improvements to the python test cases.
Before merging this commit, we would need a new self-hosted GitHub runner
instance assigned to this repository, as the device clean up routine is now
handled by the runner instance on the
ACTIONS_RUNNER_HOOK_JOB_COMPLETED.The new self-hosted runner should be created and assigned to this repository via
a different channel, as this requires a token exchange.