Plugin: Updating ScaleFlux Plugin

[benreese0]

Refactoring to have an sfx-types.h and sfx-nvme.h
Adding an equivalent to sfx-status into sfx nvme-cli plugin JSON and normal prints working
Added drive lifetime WAF in sfx status output

Co-authored-by: Ben Reese [email protected]
Co-authored-by: Jayden Stenfort [email protected]

Signed-off-by: Ben Reese [email protected]

[igaw]

Could you please split up the different changes into patches instead just one single change which does several things.

• E.g. fixing typos ('Intel' -> 'ScaleFlux')
• NVME_NSID_ALL
• moving code into the header file
• adding the newly json output

For the last point, please check your coding style here. There are plenty of whitespace violation, e.g. overlong lines, missing spaces, space and tabs mixed.

checkpatch.pl can help you here to identify those. See how to use it out of the Linux kernel tree

The general direction looks good. Thanks

[benreese0]

Thanks, I'll get those done

[benreese0]

eep, sorry, I thought I had resolved all the issues checkpatch.pl was flagging let me get that branch in the right spot

[igaw]

Thanks!

BTW, you might want to look into the _cleanup_fd_ helper. This makes the error code handling way simpler. Also, you could separate the normal output from the json ouput a bit better,e.g. by moving into separate functions and guard the json part with a ifdef. Then we can build this plugin even when json-c is not present.