Ocp set ieee1667 #2623
Merged
Ocp set ieee1667 #2623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrap API supported for MI interface. Signed-off-by: Tokunori Ikegami <[email protected]>
This is for the OCP requirement fields and bits definitions. Signed-off-by: Tokunori Ikegami <[email protected]>
ikegami-t
force-pushed
the
ocp-set-ieee1667
branch
from
90d1861 to
c578114
Compare
igaw
reviewed
Dec 16, 2024
plugins/ocp/ocp-nvme.c
Outdated
| .args_size = sizeof(args), | ||
| .fd = dev_fd(dev), | ||
| .timeout = NVME_DEFAULT_IOCTL_TIMEOUT, | ||
| .cdw11 = OCP_SET(argconfig_parse_seen(opts, "enable"), ENABLE_IEEE1667_SILO), |
Collaborator
There was a problem hiding this comment.
Please use a variable for the OCP(...) part. This is a bit too much in one line.
igaw
reviewed
Dec 16, 2024
plugins/ocp/ocp-nvme.h
Outdated
| #define OCP_PLUGIN_VERSION "2.9.3" | ||
| #include "cmd.h" | ||
|
|
||
| #define ENABLE_IEEE1667_SILO "enable IEEE1667 silo" |
Collaborator
There was a problem hiding this comment.
I would use the string directly in the command list macro. Just to keep it consistent with the rest.
The command sets enable IEEE1667 silo. Signed-off-by: Tokunori Ikegami <[email protected]>
ikegami-t
force-pushed
the
ocp-set-ieee1667
branch
from
c578114 to
db6d195
Compare
Contributor
Author
|
Just fixed for the review comments. Thank you. |
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.