dapustor: enable dapustor-nvme.c build without json-c dependencies ch… #2629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igaw
reviewed
Dec 20, 2024
| OPT_FLAG("raw-binary", 'b', &cfg.raw_binary, raw), | ||
| #ifdef CONFIG_JSONC | ||
| OPT_FLAG("json", 'j', &cfg.json, json), | ||
| #endif /* CONFIG_JSONC */ |
Collaborator
There was a problem hiding this comment.
just thinking loud: if we introduce something like
#ifdef CONFIG_JSONC
#define OPT_FLAG_JSON OPT_FLAG("json", 'j', &cfg.json, "Output In JSON format")
#else
#define OPT_FLAG_JSON
#endif
on a global level we don't need these ugly ifdefs everywhere.
Contributor
Author
There was a problem hiding this comment.
Good suggestion. Fixed this by the PR #2637. Thank you.
…eckin Only build json print codes with CONFIG_JSONC build option instead. Signed-off-by: Tokunori Ikegami <[email protected]>
igaw
force-pushed
the
dapustor-json-dep
branch
from
a370973 to
740eb69
Compare
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eckin
Only build json print codes with CONFIG_JSONC build option instead.