ocp: replace to use json_object_* macros to obj_* macros #2640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think we should not export the It's a lot of code churn and adds an additional indirection without a lot of gain. |
Also use the same prefix json_object_add_*. Signed-off-by: Tokunori Ikegami <[email protected]>
Since the field defined by the NVMe timestamp feature. Signed-off-by: Tokunori Ikegami <[email protected]>
Since the 64 bits variables not necessary to mask by 64 bits. Signed-off-by: Tokunori Ikegami <[email protected]>
This is to reduce unnecessary mask with 0x0000FFFFFFFFFFFF. Signed-off-by: Tokunori Ikegami <[email protected]>
This is to remove unnecessary mask with 0x00FFFFFFFFFFFFFF. Signed-off-by: Tokunori Ikegami <[email protected]>
ikegami-t
force-pushed
the
ocp-obj-macro
branch
from
0e98910 to
f8b0589
Compare
Contributor
Author
|
Thanks for your review comments. Just fixed the patches as suggested. |
Collaborator
|
Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since currently mixed to use them in ocp-print-json.c then unify.