Skip to content

Conversation

@mh2022-meta
Copy link
Contributor

Fixed OCP Latency Monitor stdout spacing in column header

version 2.11
image

fix
image

@igaw
Copy link
Collaborator

igaw commented Jan 3, 2025

The patch looks good, the commit message needs some more tuning:

WARNING: Missing commit description - Add an appropriate one
Error: WARNING: Missing commit description - Add an appropriate one


ERROR: Missing Signed-off-by: line(s)
Error: ERROR: Missing Signed-off-by: line(s)

The first error is due the missing prefix to your subject and there is no commit message at all.

@mh2022-meta mh2022-meta force-pushed the fix_ocp_latency_monitor_stdout_spacing branch 2 times, most recently from e94844d to df60ed3 Compare January 16, 2025 10:22
The Latency Monitor stdout has a space delimited table. This fix
properly aligns the column headers (Read, Write, and Deallocate/Trim)
with the rest of the table.

Signed-off-by: Minh Hoang (Storage HW) <[email protected]>
@mh2022-meta mh2022-meta force-pushed the fix_ocp_latency_monitor_stdout_spacing branch from df60ed3 to 5176718 Compare January 23, 2025 06:21
@igaw
Copy link
Collaborator

igaw commented May 15, 2025

Oops, sorry I missed this one. Thanks!

@igaw igaw merged commit 1fe405a into linux-nvme:master May 15, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants