ocp: Fixes for OCP 2.5 Telemetry Stats Parsing#2647
Merged
igaw merged 2 commits intolinux-nvme:masterfrom Jan 8, 2025
Merged
Conversation
igaw
reviewed
Jan 7, 2025
igaw
reviewed
Jan 7, 2025
plugins/ocp/ocp-telemetry-decode.c
Outdated
| json_add_formatted_var_size_str(pstatistics_object, STR_STATISTICS_SPECIFIC_DATA, | ||
| pdata, data_size); | ||
| if (pstatistic_entry->statistic_id == MAX_DIE_BAD_BLOCK_ID) { | ||
| json_add_formatted_u32_str(pstatistics_object, STR_STATISTICS_WORST_DIE_PERCENT, |
Collaborator
There was a problem hiding this comment.
just break the overlong line. 100 chars are wide enough for normal code. If the code block is hitting it all the time, it's usually a good indication that there is something wrong.
Contributor
Author
There was a problem hiding this comment.
fixed long code lines.
@igaw Should I squash these changes into 1 commit?
igaw
reviewed
Jan 7, 2025
The OCP 2.5 Telemetry log statistics parsing code was not checking for the end of the stats data and therefore getting stuck in an infinite while loop. Added code to parse out the statistic specific data for the Max Die, Max NAND Channel, and Min NAND Channel Bad Block. Removed unneeded brackets Fixed lines exceeding 100 chars Signed-off-by: jeff-lien-wdc <jeff.lien@sandisk.com>
jeff-lien-sndk
force-pushed
the
ocp-stats-fix
branch
from
0193672 to
8214923
Compare
Set plugin version to 2.11.0 Signed-off-by: jeff-lien-wdc <jeff.lien@sandisk.com>
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OCP 2.5 Telemetry log statistics parsing code was not checking for the end of the stats data and therefore getting stuck in an infinite while loop.
Also added code to parse out the statistic specific data for the Max Die, Max NAND Channel, and Min NAND Channel Bad Block.