Skip to content

Conversation

@plmwd
Copy link

@plmwd plmwd commented Jan 11, 2025

Lookup ascii string in VU Event Identifier String Table for vendor unique event classes. Fix not looking up spec-defined statistic id name. Fix typo ('static' => 'statistic').

@plmwd
Copy link
Author

plmwd commented Jan 22, 2025

Hi @igaw, could you please check?

@igaw
Copy link
Collaborator

igaw commented Jan 24, 2025

still not resolved:

ERROR: that open brace { should be on the previous line
#44: FILE: plugins/ocp/ocp-telemetry-decode.c:531:
+ if (identifier <= 0x1D)
+ {
Error: ERROR: that open brace { should be on the previous line

And I think the second patch should be merged into the first. If not,
please add a prefix to the summary for the second commit. But it really looks like it should be in the first.

Lookup ascii string in VU Event Identifier String Table for vendor
unique event classes. Fix typo.

Signed-off-by: Paul Wood <[email protected]>
@plmwd plmwd force-pushed the fix-string-log-string-lookup branch from 3a70a72 to e76b610 Compare January 24, 2025 22:46
@plmwd
Copy link
Author

plmwd commented Jan 24, 2025

Fixed the issue and squashed. Can you please check @igaw?

@igaw igaw merged commit 6cd285e into linux-nvme:master Jan 27, 2025
16 checks passed
@igaw
Copy link
Collaborator

igaw commented Jan 27, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants