nvme: use blkdev for direct if namespace-id specified #2665
Conversation
ikegami-t
force-pushed
the
nvme-blkdev-nsid
branch
from
2afd197 to
11004d0
Compare
|
@sukhi61166 If possible could you please test the PR chagnes since the changes for the issue #2662 but locally tested as the code itself works correctly but I do not have the device has more than one namespace for now? |
ikegami-t
force-pushed
the
nvme-blkdev-nsid
branch
from
11004d0 to
f1307a3
Compare
nvme.c
Outdated
| nvme_show_error("flush: %s", nvme_strerror(errno)); | ||
|
|
||
| if (is_chardev(dev)) | ||
| nvme_show_result("chardev handled so needed to use blkdev instead"); |
There was a problem hiding this comment.
Maybe add something like "char device provided but blkdev is needed, e.g. /dev/nvme0n1" ?
There was a problem hiding this comment.
Changed the message as suggested. Thank you.
This is to get the option value by name. Signed-off-by: Tokunori Ikegami <[email protected]>
Since IO commands rejected by the chardev if more than one namespace. Signed-off-by: Tokunori Ikegami <[email protected]>
ikegami-t
force-pushed
the
nvme-blkdev-nsid
branch
from
f1307a3 to
12e657d
Compare
Since IO commands rejected by the chardev if more than one namespace. Signed-off-by: Tokunori Ikegami <[email protected]>
ikegami-t
force-pushed
the
nvme-blkdev-nsid
branch
from
12e657d to
1a9eff1
Compare
|
Thanks! |
I will checkout the latest and try it. Thanks |
|
@sukhi61166 Unfortunately the PR changes reverted by the commmit e62ab3c for the issue #2668 introduced by the PR changes and also for the changes causing complicated as mentioned by the PR comment #2693 (comment). So for now still we need to specify the blkdev for the flush command instead of the chardev mentioned by the issue #2662. |
3 participants
Since IO commands rejected by the chardev if more than one namespace.