Nvme tests ns #2673
Nvme tests ns #2673
Conversation
Since currently only default NS blkdev checked for all NSs. Signed-off-by: Tokunori Ikegami <[email protected]>
|
The changes related to the issue #2668 but still the issue cause not sure and the blkdev checking fix may detect the cause. Also add verbose debugging option for NS management commands. |
tests/nvme_test.py
Outdated
| err = subprocess.call(id_ns_cmd, | ||
| shell=True, | ||
| stdout=subprocess.DEVNULL) | ||
| if err == 0: |
There was a problem hiding this comment.
I suppose this should be indented, only test the return value from the subprocess.call?
There was a problem hiding this comment.
Fixed the indentation. Thank you.
tests/nvme_test.py
Outdated
| create_ns_cmd = f"{self.nvme_bin} create-ns {self.ctrl} " + \ | ||
| f"--nsze={str(nsze)} --ncap={str(ncap)} --flbas={str(flbas)} " + \ | ||
| f"--dps={str(dps)}" | ||
| f"--dps={str(dps)} -v" |
There was a problem hiding this comment.
I don't know if we want the spam the output. Usually this stuff works just fine. I let @MaisenbacherD decide :)
There was a problem hiding this comment.
Understood. Thank you.
There was a problem hiding this comment.
I am fine with enabling verbosity output for tests, as this might give hints why a test failed when skimming though the logs.
However, can we please use the long version of the options for scripting (e.g. --verbose)? :)
There was a problem hiding this comment.
Right so fixed to the long version option. Thank you.
To make sure the blkdev as same with NS attachment. Signed-off-by: Tokunori Ikegami <[email protected]>
ikegami-t
force-pushed
the
nvme-tests-ns
branch
from
d463a3d to
9ea6705
Compare
This is for debugging output if test failed. Signed-off-by: Tokunori Ikegami <[email protected]>
ikegami-t
force-pushed
the
nvme-tests-ns
branch
from
9ea6705 to
388bc3f
Compare
MaisenbacherD
left a comment
MaisenbacherD
left a comment
There was a problem hiding this comment.
Looks good to me :)
|
Thanks! |
3 participants
No description provided.