nvme-print: misc fixes to a few verbose outputs #2696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add descriptions for the nsze, ncap & nuse fields in the verbose output of the id-ns command for better clarity. For e.g. nvme id-ns /dev/nvme1n1 -v dev: /dev/nvme1n1, fd: 3 NVME Identify Namespace 1: nsze : 0x280000 Total size in logical blocks ncap : 0x280000 Maximum size in logical blocks nuse : 0x13b3e Current size in logical blocks ... Signed-off-by: Martin George <[email protected]>
Add identifier & NSID tags in the verbose output of the list-ns command for better clarity. And while at it, print a common "NVMe Namespace List" tag at the top too. For e.g. nvme list-ns /dev/nvme1n1 -v dev: /dev/nvme1n1, fd: 3 NVME Namespace List: Identifier 0: NSID 0x1 Identifier 1: NSID 0x2 ... Signed-off-by: Martin George <[email protected]>
Collaborator
|
Thanks! I just realized we need to fix the '-v' debug output for the file handles. Now I remember why I didn't like it in the first place :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.