nvme-print-binary: fix to output reachability associations log length#2708
nvme-print-binary: fix to output reachability associations log length#2708igaw merged 4 commits intolinux-nvme:masterfrom
Conversation
ikegami-t
force-pushed
the
ra-log-len
branch
from
1932224 to
24e9d69
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nvme-print-json.c
Outdated
| char json_str[STR_LEN]; | ||
| struct json_object *rad; | ||
|
|
||
| obj_add_debug(uint64, r, "len", len); |
There was a problem hiding this comment.
I am not sure if we should add debug output to the json output. For debugging purposes we have the normal output.
There was a problem hiding this comment.
Fixed to delete the debug output but added to use UNUSED macro instead since the len parameter not used.
nvme-print-binary.c
Outdated
| static void binary_reachability_groups_log(struct nvme_reachability_groups_log *log, __u64 len) | ||
| { | ||
| d_raw((unsigned char *)log, sizeof(*log)); | ||
| print_debug("len: %"PRIu64"\n", (uint64_t)len); |
There was a problem hiding this comment.
Same comment as with the json output. I don't know if we want to add to every output format debug information. I am fine with having the normal output format annotated for debugging purposes, but adding trippling the debug output seems add unnecessary maintenance burden.
There was a problem hiding this comment.
Yes agreed then delete the output.
ikegami-t
force-pushed
the
ra-log-len
branch
3 times, most recently
from
a2af098 to
21218ee
Compare
|
I've just updated the cross build containers, the newer tool chains finds a bunch of new bugs. Don't worry about them, I'll fix them up. |
|
I see and noted. Thank you. |
|
The build works again. Could you rebase to the current HEAD? Thanks! |
Previously only the log header output since the log length is changeable. The changes to output the changeable log length correctly. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Previously only the log header output since the log length is changeable. The changes to output the changeable log length correctly. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
…ength Previously only the log header output since the log length is changeable. The changes to output the changeable log length correctly. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Previously incorrectly the log length is calculated by the LE log data. So fix to convert the value from LE to host endian for the calculation. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
ikegami-t
force-pushed
the
ra-log-len
branch
from
21218ee to
bf30afb
Compare
|
Sure done then all checks passed. Thank you. |
|
Thanks! |
2 participants
Previously only the log header output since the log length is changeable. This changes to output the changeable log length correctly.