Merged
Conversation
ikegami-t
force-pushed
the
nvme-feat-extension
branch
from
fe209d8 to
d56673c
Compare
Collaborator
|
I like the approach to group the getter/setters for the features into a plugin. The top level is a bit crowded :) Could you rebase, it conflicts with the recent merges. Thanks! |
Currenty allocation error string set if the variable was NULL. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Then show_perror print function outputs the message with a va_list. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
This extension is for adding each features commands to get and set. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Use the variable instead of the hardcorded and duplicated strings. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
ikegami-t
force-pushed
the
nvme-feat-extension
branch
from
2f9d425 to
915a41e
Compare
Contributor
Author
|
Rebased the changes with the conflict resolved. Thank you. |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.