OCP Telemetry Data Statistics Parsing Fix#2763
Merged
igaw merged 1 commit intolinux-nvme:masterfrom Apr 2, 2025
Merged
Conversation
…_str These 2 functions, used by the ocp plugin, had string arrays with hard coded lengths. In some cases, the hard coded length was not long enough for strings that were being printed. The functions were changed to allocate a buffers long enough to contain the full string. Updated the OCP plugin version to 2.12.0 Signed-off-by: jeff-lien-wdc <jeff.lien@sandisk.com>
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function print_formatted_var_size_str (in util/utils.c) which is used to print the telemetry statistics additional data had a string array (used for printing out the data) with a hard coded length of 1024 chars. The Stats data with 80 DW's of data would exceed the size of that array. Therefore, the code was changed to allocate a buffer large enough to contain the full string data.