updating micron plugin with latest models support added#2772
updating micron plugin with latest models support added#2772sivaprasad6541 wants to merge 2 commits intolinux-nvme:masterfrom
Conversation
|
@sivaprasad6541 the reason I haven't pulled it yet, is that there are many whitespace issues reported by checkpatch, e.g. inconsistent indention etc. Please address the issues reported by checkpath, but the invidiual errors/warnings with a grain of salt. Checkpatch is a bit overeager and not everything make sense. Generally follow the kernel coding style. Thanks! |
| nvme_print_flags_t flags; | ||
|
|
||
| struct { | ||
| char *err; |
There was a problem hiding this comment.
why not
const char *| struct json_object *logPages = NULL; | ||
| struct json_object *stats = NULL; | ||
| int field_count = ARRAY_SIZE(ocp_c0_log_page); | ||
| int field_count = 0; |
There was a problem hiding this comment.
probably should be an unsigned type
There was a problem hiding this comment.
As we pass this field to generic_parser as a parameter, we had to use just int.
plugins/micron/micron-nvme.c
Outdated
| struct json_object *root; | ||
| struct json_object *logPages; | ||
| struct json_object *stats = NULL; | ||
| int field_count = ARRAY_SIZE(hyperscale_c0_log_page); |
There was a problem hiding this comment.
probably should be an unsigned type
There was a problem hiding this comment.
As we pass this field to generic_parser as a parameter, we had to use just int.
| int val; | ||
| } pcie_correctable_errors[] = { | ||
| { "Unsupported Request Error Status (URES)", 20, | ||
| { (char *)"Unsupported Request Error Status (URES)", 20, |
There was a problem hiding this comment.
Just change type to 'const char *' and casting won't be needed.
3 participants
No description provided.