Skip to content

nvme: plot eye chart data and hex dumping VS eye data #2828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sivaprasad6541 wants to merge 7 commits into from
Closed

nvme: plot eye chart data and hex dumping VS eye data #2828

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f45b402
nvme: plot eye chart data and hex dumping VS eye data
sivaprasad6541 May 27, 2025
d69c312
plugins/micron: update authors list
sivaprasad6541 May 27, 2025
a404eb3
nvme: plot eye chart and hex dumping VS eye data
sivaprasad6541 May 29, 2025
1b18547
nvme: eye chart plotting and dump VS eye data
sivaprasad6541 May 29, 2025
43097ad
nvme: eye chart plotting and dump VS eye data
sivaprasad6541 Jun 4, 2025
1b88468
wdc: Fix for vs-smart-add-log wdc plugin command
jeff-lien-sndk May 27, 2025
6226e29
Merge branch 'master' into pull-and-parse-eye-data-19h
sivaprasad6541 Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions nvme-print-stdout.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,9 +776,9 @@ static void stdout_eom_printable_eye(struct nvme_eom_lane_desc *lane)
char *eye = (char *)lane->eye_desc;
int i, j;

for (i = 0; i < lane->nrows; i++) {
for (j = 0; j < lane->ncols; j++)
printf("%c", eye[i * lane->ncols + j]);
for (i = 0; i < le16_to_cpu(lane->nrows); i++) {
for (j = 0; j < le16_to_cpu(lane->ncols); j++)
printf("%c", eye[i * le16_to_cpu(lane->ncols) + j]);
printf("\n");
}
}
Expand Down Expand Up @@ -809,16 +809,16 @@ static void stdout_phy_rx_eom_descs(struct nvme_phy_rx_eom_log *log)
stdout_eom_printable_eye(desc);

/* Eye Data field is vendor specific */
if (desc->edlen == 0)
if (le16_to_cpu(desc->edlen) == 0)
continue;

/* Hex dump Vendor Specific Eye Data */
vsdata = malloc(desc->edlen);
vsdataoffset = (desc->nrows * desc->ncols) +
vsdata = malloc(le16_to_cpu(desc->edlen));
vsdataoffset = (le16_to_cpu(desc->nrows) * le16_to_cpu(desc->ncols)) +
Copy link
Collaborator

@igaw igaw Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please introduce local varables instead redoing the cpu conversion everytime.

Copy link
Contributor Author

@sivaprasad6541 sivaprasad6541 Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified as suggested.

sizeof(struct nvme_eom_lane_desc);
vsdata = (unsigned char *)((unsigned char *)desc + vsdataoffset);
printf("Eye Data:\n");
d(vsdata, desc->edlen, 16, 1);
d(vsdata, le16_to_cpu(desc->edlen), 16, 1);
printf("\n");

p += log->dsize;
Expand Down