Merged
Conversation
igaw
reviewed
Jun 2, 2025
plugins/feat/feat-nvme.c
Outdated
| OPT_BYTE("ab", 'a', &cfg.ab, ab), | ||
| OPT_BYTE("lpw", 'l', &cfg.lpw, lpw), | ||
| OPT_BYTE("mpw", 'm', &cfg.mpw, mpw), | ||
| OPT_BYTE("hpw", 'h', &cfg.hpw, hpw)); |
Contributor
Author
There was a problem hiding this comment.
Yes right. so fixed to -H. Sorry for this error. Thank you.
igaw
reviewed
Jun 2, 2025
plugins/feat/feat-nvme.c
Outdated
| __u8 ab; | ||
| __u8 lpw; | ||
| __u8 mpw; | ||
| __u8 hpw; |
Collaborator
There was a problem hiding this comment.
just have them in one line.
also reorder deceleration to look more like in inverse christmas tree. E.g
enum nvme_get_features_sel sel = NVME_GET_FEATURES_SEL_CURRENT;
bool save = argconfig_parse_seen(opts, "save");
__u8 ab, lpw, mpw, hpw;
__u32 result;
int err;
Contributor
Author
There was a problem hiding this comment.
Easy to read then fixed as mentioned. Thank you.
Also fixed temp-thresh command string and added get-feature print. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Collaborator
|
Thanks! Sorry for the long delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixed temp-thresh command string and added get-feature print.