Skip to content

Conversation

@ikegami-t
Copy link
Contributor

This is for Volatile Write Cache feature to get and set.

This is for Volatile Write Cache feature to get and set.

Signed-off-by: Tokunori Ikegami <[email protected]>
@keithbusch
Copy link
Contributor

There's a lot of features, i don't think any one of them needs to be a top level command. We already have the "get-feature" and "set-feature" which can easily access this. If you want to have symbolic names instead of having to remember the feature-id value, then sure, that might be helpful.

@keithbusch
Copy link
Contributor

oh, you all have already made a sub-command for all these. Well, I guess it's too late to go back now.

@ikegami-t
Copy link
Contributor Author

ikegami-t commented Jul 8, 2025

Thanks for your reviewing and comments.

There's a lot of features, i don't think any one of them needs to be a top level command. We already have the "get-feature" and "set-feature" which can easily access this. If you want to have symbolic names instead of having to remember the feature-id value, then sure, that might be helpful.

Yes will try to add the symbolic names later.

oh, you all have already made a sub-command for all these. Well, I guess it's too late to go back now.

The feat plugin commands can be set the feature dword or data fields values directly.

@ikegami-t
Copy link
Contributor Author

Just pushed the PR: #2859 for the symbolic names.

@igaw igaw merged commit bee791f into linux-nvme:master Jul 11, 2025
17 checks passed
@igaw
Copy link
Collaborator

igaw commented Jul 11, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants