ocp: Fixes to telemetry-string-log command#2897
Conversation
jeff-lien-sndk
force-pushed
the
telemetry-string-log
branch
from
7c11da6 to
e26e632
Compare
plugins/ocp/ocp-nvme.c
Outdated
| OPT_FMT("output-format", 'o', &cfg.output_format, | ||
| OPT_FMT("output-format", 'f', &cfg.output_format, | ||
| "output Format:normal|json|binary"), | ||
| OPT_FILE("output-file", 'o', &cfg.output_file, output_file), |
There was a problem hiding this comment.
Not sure about the -o. nvme-cli switched over to use -o for --output-format everywhere. It was a bit painful but now it is there and it is consistent. This here will introduce a regression and people will certainly complain.
There was a problem hiding this comment.
btw, we don't have a man page for this command either ;)
There was a problem hiding this comment.
I will create a man page for this command.
As for the -o change, I can change it back, but then think we need to swap the -o and -f parms in the ocp internal-log command. Currently that command uses -f for output-format and -o for output-file.
There was a problem hiding this comment.
Ah, I see. I thought that the ocp plugin also uses the -o consistently for the output format. I think it would be good if we stick throughout nvme-cli for a few global arguments
- -v/--verbose
- -o/--output-format
- --output-format-version
- -t/--timeout
- --dry-run
There was a problem hiding this comment.
@igaw
Updated and fixed the man page.
changed output-format back to use -o and output-file to use -f.
jeff-lien-sndk
force-pushed
the
telemetry-string-log
branch
3 times, most recently
from
68051e7 to
3063bda
Compare
Added option to specify output-file Fix telemetry-string-log output file initialization Signed-off-by: jeff-lien-sndk <jeff.lien@sandisk.com> Reviewed-by: brandon-paupore-sndk <brandon.paupore@sandisk.com>
Renamed nvme-ocp-telemetry-string-log-page.txt to nvme-ocp-telemetry-string-log.txt so it now matches the command name. Added the output-filename options to man page documentation. Signed-off-by: jeff-lien-sndk <jeff.lien@sandisk.com>
jeff-lien-sndk
force-pushed
the
telemetry-string-log
branch
from
3063bda to
c9c4565
Compare
|
Thanks! |
2 participants
Added option to specify output-file
The output_format input parm should use -f and the output_file parm should use -o to match the internal-log command.
The output file initialization will add .bin to the passed in output file parm.