Enable data area 4 internal-log ocp plugin command #2901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-lien-sndk
force-pushed
the
enable-da4-ocp
branch
2 times, most recently
from
2800364 to
1ce97b7
Compare
The current ocp internal-log command will only retrieve up to data area 3. This change will enable retrieving of all 4 telemetry log data areas. It will also refactor the code used to save off the 2 files collected: telemetry log and string log along with the 1 generated file: the parsed da 1 and 2 data. Swap -o and -f on output-format and output-file parameters. Signed-off-by: jeff-lien-sndk <[email protected]> Reviewed-by: brandon-paupore-sndk <[email protected]>
The man page documentation has been updated to document the change of -o for output-format and -f for output-file. Also there have been updates made to note new supported data areas. Signed-off-by: jeff-lien-sndk <[email protected]> Reviewed-by: brandon-paupore-sndk <[email protected]>
jeff-lien-sndk
force-pushed
the
enable-da4-ocp
branch
from
1ce97b7 to
573b237
Compare
Collaborator
|
Looks good. I haven't checked but it might be necessary to update the tab completions for bash and zsh as well. |
Contributor
Author
|
@igaw What tab completions? I haven't done that in any previous PR's. |
Collaborator
|
I keep forgetting to ask to update the those files whenever a command gets new/changes arguments. In this case it would be this here: nvme-cli/completions/bash-nvme-completion.sh Line 1599 in a6d01ef Line 191 in a6d01ef |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current ocp internal-log command will only retrieve up to data area 3. This change will enable retrieving of all 4 telemetry log data areas.
It will also refactor the code used to save off the 2 files collected: telemetry log and string log along with the 1 generated file: the parsed da 1 and 2 data.
Swap -o and -f on output-format and output-file parameters.