Skip to content

List generic table #2924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igaw merged 7 commits into from
Oct 8, 2025
Merged

List generic table #2924

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
40cc867
util: add table_init_with_columns() function
ikegami-t Oct 1, 2025
3970e96
util: allow table_add_columns() to set column width
ikegami-t Oct 1, 2025
ffe640a
util: remove unnecessary row end padding print
ikegami-t Oct 1, 2025
d85e800
nvme-print-stdout: replace nvme simple list with generic table
ikegami-t Oct 1, 2025
443c9ae
util: use switch case statements instead of repeated else if
ikegami-t Oct 1, 2025
68bfb16
util: move to add final padding printf between each columns
ikegami-t Oct 7, 2025
747a6e2
util: rename table_init() to table_create()
ikegami-t Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions util/table.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,16 +211,32 @@ void table_add_row(struct table *t, int row_id)

struct table *table_init(void)
{
struct table *t;
struct table *t = malloc(sizeof(struct table));
Copy link
Collaborator

@igaw igaw Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function could just be return calloc(1, sizeof(struct table));. Maybe we should drop the function as there is no real value in it and use calloc directly where currently table_init is used. Or do I miss something?

Copy link
Collaborator

@igaw igaw Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see, table_free is doing some work and to keep the symetry table_init makes sense. But I think the name shouldbe table_create or so. It's not initializing anything, it's just allocation it.


t = malloc(sizeof(struct table));
if (!t)
return NULL;

memset(t, 0, sizeof(struct table));

return t;
}

struct table *table_init_with_columns(struct table_column *c, int num_columns)
{
struct table *t = table_init();

if (!t)
return NULL;

if (table_add_columns(t, c, num_columns)) {
table_free(t);
return NULL;
}

return t;

Copy link
Collaborator

@igaw igaw Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary empy line.

}

static int table_add_column(struct table *t, struct table_column *c)
{
struct table_column *new_columns;
Expand Down
12 changes: 12 additions & 0 deletions util/table.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,4 +146,16 @@ void table_add_row(struct table *t, int row);
void table_print(struct table *t);
void table_free(struct table *t);

/**
* table_init_with_columns() - Allocate a table instance with column definitions
* @c: Column definitions
* @num_columns:Number of columns
*
* This is a function combined table_init() and table_add_columns().
*
* Return: The table instance, or NULL if unsuccessful. If allocated, the caller
* is responsible to free the table.
*/
struct table *table_init_with_columns(struct table_column *c, int num_columns);

#endif /* _TABLE_H_ */